Repository navigation
Check if a double is NaN before converting to it int - #61940
Merged
fluttergithubbot merged 4 commits intoJul 23, 2020
Merged
Conversation
fluttergithubbot
added
the
framework
Piinks
approved these changes
Jul 21, 2020
| /// This function assumes the given point has a z-coordinate of 0.0. The | ||
| /// z-coordinate of the result is ignored. | ||
| /// | ||
| /// While not common, this method may return (NaN, NaN), iff the given `point` |
Contributor
There was a problem hiding this comment.
Just checking - 'iff' as in 'if and only if', or typo?
Contributor
Author
There was a problem hiding this comment.
Yeah I meant "if and only if".
justinmc
approved these changes
Jul 21, 2020
justinmc
left a comment
justinmc
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I ran into something vaguely similar but not quite the same while working with matrix math in InteractiveViewer. Some Matrix4 methods would fail in strange ways when given infinite numbers. I'm glad this will handle things in a more sane way now at least 👍
13 tasks
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This was referenced Sep 18, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
RenderObject.localToGlobalmay return(NaN, NaN)when(x, y, 0, 1)is transformed to a point at infinity. This is generally not a problem, as painting is usually skipped when the transform is set to zero. But trying to convert the point's coordinates to int or json will throw.Related Issues
#9344
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.