Skip to content

SelectableText handles after Select All - #62072

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
justinmc:select-all-handles
Jul 29, 2020
Merged

SelectableText handles after Select All#62072
fluttergithubbot merged 2 commits into
flutter:masterfrom
justinmc:select-all-handles

Conversation

@justinmc

@justinmc justinmc commented Jul 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

The text selection handles weren't showing after pressing "Select All" in a SelectableText widget. This PR makes them show up.

Screen Shot 2020-07-22 at 3 30 05 PM

Related Issues

Closes #59600

Tests

I added the following tests:

  • Test that the handles show up on all platforms.

@justinmc
justinmc requested a review from chunhtai July 22, 2020 22:30
@justinmc justinmc self-assigned this Jul 22, 2020
@fluttergithubbot fluttergithubbot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Jul 22, 2020
chunhtai
chunhtai approved these changes Jul 28, 2020
View reviewed changes

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit a4d570f into flutter:master Jul 29, 2020
@justinmc
justinmc deleted the select-all-handles branch July 29, 2020 15:53
@nathanael-h nathanael-h mentioned this pull request Jul 29, 2020
Closed
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@justinmc @Pragya007
SelectableText handles after Select All (flutter#62072)
25caa87
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@justinmc @mingwandroid
SelectableText handles after Select All (flutter#62072)
a4ffafa
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chunhtai chunhtai chunhtai approved these changes

Assignees

@justinmc justinmc

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SelectableText has no selection handle on iOS when long press

4 participants

@justinmc @chunhtai @googlebot @fluttergithubbot