Repository navigation
Measure CPU/GPU with the simple animation test - #63124
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1 similar comment
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
Bot
added
the
c: contributor-productivity
|
@iskakaushik @flar @gaaclarke : I've cleaned up the PR and it's ready for review. |
Additionally, I also enabled CPU/GPU measurements for the complex layout scroll test because the macrobenchmark app is having some troubles in my local environment although it works fine in the device lab. In case that the device lab tasks become flaky after this PR, having data on two tasks would help us rule out where the problem is.
liyuqian
added
perf: energy
|
Just a comment on prior work - would the flag read better as "needs measure" feels odd to me, though I suppose there is a feature called "measureCpuGpu" and this benchmark needs that feature, but since it starts with a verb, "needs [verb]" reads awkwardly... |
Sounds good. I'll rename it and track the progress in #63227. |
4 participants
Additionally, I also enabled CPU/GPU measurements for the complex layout
scroll test because the macrobenchmark app is having some troubles in my
local environment although it works fine in the device lab. In case that
the device lab tasks become flaky after this PR, having data on two
tasks would help us rule out where the problem is.