Skip to content

Check that header exists instead of contents of header in build iOS module test - #65961

Merged
jmagman merged 1 commit into
flutter:masterfrom
jmagman:test-header
Sep 17, 2020
Merged

Check that header exists instead of contents of header in build iOS module test#65961
jmagman merged 1 commit into
flutter:masterfrom
jmagman:test-header

Conversation

@jmagman

@jmagman jmagman commented Sep 16, 2020

Copy link
Copy Markdown
Member

Description

flutter-team-archive/engine#21193 changed the import. Check that the header exists, instead of checking the contents. This will avoid a manual engine roll.

Related Issues

#60025 (comment)

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically labels Sep 16, 2020
@jmagman
jmagman requested review from cbracken and xster September 16, 2020 19:56
@jmagman jmagman self-assigned this Sep 16, 2020
@jmagman

jmagman commented Sep 16, 2020

Copy link
Copy Markdown
Member Author 
Task result:
{
  "success": true,
  "data": null,
  "benchmarkScoreKeys": []
}

@jmagman jmagman mentioned this pull request Sep 16, 2020
Open
cbracken
cbracken approved these changes Sep 17, 2020
View reviewed changes

@cbracken cbracken left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

LGTM stamp from a Japanese personal seal

@jmagman

jmagman commented Sep 17, 2020

Copy link
Copy Markdown
Member Author

Linux hostonly_devicelab_tests was a Gradle download flake, it passed at https://ci.chromium.org/p/flutter/builders/try/Linux%20hostonly_devicelab_tests/2531

@jmagman
jmagman merged commit c61c8f3 into flutter:master Sep 17, 2020
@jmagman
jmagman deleted the test-header branch September 17, 2020 22:17
goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
@jmagman @goderbauer
Check that header exists instead of content (flutter#65961)
c6621cd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cbracken cbracken cbracken approved these changes
@xster xster Awaiting requested review from xster

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @cbracken @googlebot