Skip to content

Revert "TextSelectionTheme support (step 2 of 3)" - #66051

Merged
jonahwilliams merged 1 commit into
masterfrom
revert-65044-text_selection_theme_opt_in
Sep 17, 2020
Merged

jonahwilliams merged 1 commit into
masterfrom
revert-65044-text_selection_theme_opt_in

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Reverts #65044

Trying to rule out this PR as the cause of the cull_opacity_perf__timeline_summary timeout. Fyi @darrenaustin

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Sep 17, 2020

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@jonahwilliams
jonahwilliams merged commit a3aeab0 into master Sep 17, 2020
@jonahwilliams
jonahwilliams deleted the revert-65044-text_selection_theme_opt_in branch September 17, 2020 18:43
@darrenaustin

Copy link
Copy Markdown
Contributor

Wow, sorry I missed this. I am not sure what I did wrong with gold, but I will take a look and make sure I don't do it again. Thanks for dealing with this.

goderbauer pushed a commit to goderbauer/flutter that referenced this pull request Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants