Skip to content

Revert "migrate some material files to nullsafety" - #67183

Merged
renyou merged 1 commit into
masterfrom
revert-67078-nnbd-material-part
Oct 3, 2020
Merged

renyou merged 1 commit into
masterfrom
revert-67078-nnbd-material-part

Conversation

@goderbauer

Copy link
Copy Markdown
Member

Reverts #67078

This is failing tests in google. Will investigate on Monday.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Oct 3, 2020
@goderbauer

goderbauer commented Oct 3, 2020 •

Copy link
Copy Markdown
Member Author

/cc @a14n @Hixie @renyou

@nturgut nturgut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for revert.

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hixie

Hixie commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

cc @pcsosinski for visibility

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

@renyou

renyou commented Oct 3, 2020

Copy link
Copy Markdown
Contributor

Google testing failed because of merge conflict. I will merge this one now.

@renyou
renyou merged commit a0a65fc into master Oct 3, 2020
@renyou
renyou deleted the revert-67078-nnbd-material-part branch October 3, 2020 11:54
goderbauer added a commit to goderbauer/flutter that referenced this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants