Repository navigation
Reland "migrate some material files to nullsafety (#67078)" - #67318
Merged
Merged
Conversation
flutter-dashboard
Bot
added
p: material_ui
goderbauer
force-pushed
the
relandmaterialnnbd
branch
from
October 5, 2020 17:44
7c61f16 to
d84c2d4
Compare
Member
Author
|
/cc @a14n @Hixie @pcsosinski |
goderbauer
force-pushed
the
relandmaterialnnbd
branch
from
October 5, 2020 20:13
4f53522 to
0053366
Compare
goderbauer
commented
Oct 5, 2020
Comment on lines
+2723
to
+2715
| Future<void> close() async { | ||
| void close() { |
Member
Author
There was a problem hiding this comment.
This was the reason for the google3 failure: In #67078 this method was marked async, which changes the timing slightly for tests. There's no need for it to be async, though. The main goal of this commit is to revert that.
Member
Author
|
Landing, since the tree is actually green, but not reported properly (according to @jonahwilliams). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit a0a65fc.
Google failures were cased by marking
_StandardBottomSheetState.close()asasyncin #67078:https://github.com/flutter/flutter/pull/67078/files#diff-ad7e5ee7be5375e4242652ddc6448da7R2723
This changed the timing slightly in tests. Since there is no need for that method to be
async, I am reverting that change to restore the old behavior. Additionally, I also cleaned up the nullability ofScaffold.geometryOfand_StandardBottomSheet.animationControllerto simplify the code.See the last commit for changes over #67078.