Skip to content

Revert "Actually consume top padding in bottomsheet if scrollcontrolled" - #70392

Merged
fluttergithubbot merged 1 commit into
masterfrom
revert-66257-bottomsheet-top-padding
Nov 13, 2020
Merged

fluttergithubbot merged 1 commit into
masterfrom
revert-66257-bottomsheet-top-padding

Conversation

@Piinks

@Piinks Piinks commented Nov 12, 2020 •

Copy link
Copy Markdown
Contributor

Reverts #66257

FYI @Kavantix
This was found to break some valid use cases in further google testing. We may have to come up with a different approach.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Nov 12, 2020
@google-cla google-cla Bot added the cla: yes label Nov 12, 2020

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Kavantix

Copy link
Copy Markdown
Contributor

What were these usecases?

@Piinks

Piinks commented Nov 12, 2020

Copy link
Copy Markdown
Contributor Author

I've re-opened #39205, let's move discussion there. :)

@fluttergithubbot

Copy link
Copy Markdown
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac build_gallery has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot
fluttergithubbot merged commit 477a424 into master Nov 13, 2020
@fluttergithubbot
fluttergithubbot deleted the revert-66257-bottomsheet-top-padding branch November 13, 2020 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants