Skip to content

Automatically fill in the menu button when there's a drawer - #716

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:auto_menu
Dec 4, 2015
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:auto_menu

Conversation

@abarth

@abarth abarth commented Dec 4, 2015

Copy link
Copy Markdown
Contributor

Also, fill in a back arrow when we can go back.

Fixes #699

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BackArrow?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just bite the bullet and support all the fields. It's weird to have just some supported.

@Hixie

Hixie commented Dec 4, 2015

Copy link
Copy Markdown
Contributor

LGTM

Also, fill in a back arrow when we can go back.

Fixes flutter#699
abarth added a commit that referenced this pull request Dec 4, 2015
Automatically fill in the menu button when there's a drawer
@abarth
abarth merged commit 2b47efc into flutter:master Dec 4, 2015
@abarth
abarth deleted the auto_menu branch December 4, 2015 00:37
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dealing with the Drawer hamburger menu is a lot of boilerplate code

2 participants