Skip to content

Implement ImageRepeat - #762

Merged
abarth merged 1 commit into
flutter:masterfrom
abarth:image_repeat
Dec 5, 2015
Merged

abarth merged 1 commit into
flutter:masterfrom
abarth:image_repeat

Conversation

@abarth

@abarth abarth commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

Fixes #158

@abarth

abarth commented Dec 5, 2015

Copy link
Copy Markdown
Contributor Author

@Hixie

@Hixie

Hixie commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

LGTM.
I love the approach, it's very self-contained and readable.

@abarth

abarth commented Dec 5, 2015

Copy link
Copy Markdown
Contributor Author

I love the approach, it's very self-contained and readable.

\o/

abarth added a commit that referenced this pull request Dec 5, 2015
@abarth
abarth merged commit 503218c into flutter:master Dec 5, 2015
@abarth
abarth deleted the image_repeat branch December 5, 2015 09:12
@Hixie

Hixie commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

does this clip to the output rect? seems like it might overflow if the slices don't exactly line up with the destination.

@abarth

abarth commented Dec 5, 2015

Copy link
Copy Markdown
Contributor Author

That's a good point. I was testing with a full-screen widget, so I didn't notice. Please file a bug against me. Will fix.

@Hixie

Hixie commented Dec 5, 2015

Copy link
Copy Markdown
Contributor

#766

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement (or remove) all the ImageRepeat logic.

2 participants