Skip to content

Remove mac/ios agents and remove flaky flag from mac/ios on LUCI. - #76576

Merged
godofredoc merged 1 commit into
flutter:masterfrom
godofredoc:remove_mac_ios_agent
Feb 24, 2021
Merged

Remove mac/ios agents and remove flaky flag from mac/ios on LUCI.#76576
godofredoc merged 1 commit into
flutter:masterfrom
godofredoc:remove_mac_ios_agent

Conversation

@godofredoc

@godofredoc godofredoc commented Feb 23, 2021

Copy link
Copy Markdown
Contributor

Mac/ios LUCI test beds and tests are now stable. We are removing the flaky flag to make them block the tree on failures and we are also removing the mac/ios agent configurations.

Bug: #73392

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Feb 23, 2021
@google-cla google-cla Bot added the cla: yes label Feb 23, 2021
keyonghan
keyonghan approved these changes Feb 23, 2021
View reviewed changes

@keyonghan keyonghan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman

jmagman commented Feb 23, 2021

Copy link
Copy Markdown
Member

Does any of this need to be investigated? It's not inspiring confidence...
Screen Shot 2021-02-22 at 7 10 48 PM

@godofredoc

godofredoc commented Feb 23, 2021

Copy link
Copy Markdown
Contributor Author

Does any of this need to be investigated? It's not inspiring confidence...
Screen Shot 2021-02-22 at 7 10 48 PM

Yes, we need to validate why those entries do not exist in the data models.

@godofredoc

godofredoc commented Feb 23, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Does any of this need to be investigated? It's not inspiring confidence...
Screen Shot 2021-02-22 at 7 10 48 PM

Yes, we need to validate why those entries do not exist in the data models.

This is the bug tracking the problem with the metrics: #76582

@godofredoc

godofredoc commented Feb 24, 2021

Copy link
Copy Markdown
Contributor Author

Landing for a subset of tests.

@godofredoc
godofredoc merged commit e07c248 into flutter:master Feb 24, 2021
@godofredoc
godofredoc deleted the remove_mac_ios_agent branch February 24, 2021 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yusufm yusufm Awaiting requested review from yusufm
@jmagman jmagman Awaiting requested review from jmagman
1 more reviewer
@keyonghan keyonghan keyonghan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@godofredoc @jmagman @keyonghan