Repository navigation
Move iOS codesigning into assemble build target - #77664
Merged
Merged
Conversation
jmagman
commented
Mar 9, 2021
Member
Author
There was a problem hiding this comment.
Had to stop filtering out Headers and Modules directories or the codesigning done before the copy became invalid.
Comment on lines
239
to
241
Member
Author
There was a problem hiding this comment.
I don't think this is needed now, the clang command will throw if it fails.
flutter/packages/flutter_tools/lib/src/macos/xcode.dart
Lines 189 to 192 in 9f47adc
Member
Author
There was a problem hiding this comment.
These didn't need to be async.
jmagman
force-pushed
the
assemble-codesigning
branch
from
March 9, 2021 02:51
c9b6c39 to
3c097c3
Compare
Contributor
|
(Thats a nice improvement!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flutter assemble debug_ios_bundle_flutter_assets.xcode_backendthinning and into theIosAssetBundle(debug_ios_bundle_flutter_assetsetc) assemble target as the last step of building that framework. This allows codesigning to be skipped if the App.framework doesn't need to be rebuilt.xcode_backendand into theUnpackIOS(debug_unpack_iosetc) assemble target as the last step of copying around that framework.Flutter.frameworkis codesigned withHeadersandModulesdirectories (necessary for linking) which means those directories can't be removed during embedding, or the codesigning validation on install will fail. So stop removing those directories from the final embedded app (they are really small).Confirmed when the code signing identity changes, the frameworks are re-signed (because the assemble inputs changed).
Added unit tests, but also covered by
ios_content_validation_test.Second compilation getting faster (see #77420):
Part of #67580
See also #77329 and #77007