Skip to content

Revert "Remove keyLabel and debugName from Logical/PhysicalKeyboardKey" - #79005

Merged
dkwingsmt merged 1 commit into
masterfrom
revert-78263-remove-logical-keylabel
Mar 24, 2021
Merged

dkwingsmt merged 1 commit into
masterfrom
revert-78263-remove-logical-keylabel

Conversation

@dkwingsmt

Copy link
Copy Markdown
Contributor

Reverts #78263 because it causes compiling breakagage.

@flutter-dashboard flutter-dashboard Bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Mar 24, 2021
@google-cla google-cla Bot added the cla: yes label Mar 24, 2021

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkwingsmt
dkwingsmt merged commit eb6e567 into master Mar 24, 2021
@dkwingsmt
dkwingsmt deleted the revert-78263-remove-logical-keylabel branch March 24, 2021 20:31
@dkwingsmt

Copy link
Copy Markdown
Contributor Author

Landing revert before checks.

dkwingsmt added a commit that referenced this pull request Mar 24, 2021
@dkwingsmt dkwingsmt added the a: text input Entering text in a text field or keyboard related problems label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants