Skip to content

Remove extended attributes from entire Flutter project - #81435

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:xattr
May 6, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:xattr

Conversation

@jmagman

@jmagman jmagman commented Apr 29, 2021 •

Copy link
Copy Markdown
Member

Revert #81342, users reported that didn't fix #80978.

Instead of just removing the Finder extended attributes from the ios directory, do it for the entire Flutter project directory since users are reporting this is related to images in an asset directory in the root of their project.

Fixes #80978

@jmagman jmagman added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. t: xcode "xcodebuild" on iOS and general Xcode project management labels Apr 29, 2021
@jmagman jmagman self-assigned this Apr 29, 2021
@google-cla google-cla Bot added the cla: yes label Apr 29, 2021

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts #81342.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of removing from the IosProject directory, remove from the entire project directory.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverts #81342.

@jmagman

jmagman commented May 4, 2021

Copy link
Copy Markdown
Member Author

User confirmed this fixed their issue #80978 (comment)

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman

jmagman commented May 6, 2021

Copy link
Copy Markdown
Member Author

@zanderso You removed the waiting for tree to go green label?

@zanderso

zanderso commented May 6, 2021

Copy link
Copy Markdown
Member

Ah, I misunderstood a conversation I had with @godofredoc. I've added back the tag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

4 participants