Skip to content

Fix slider notifies start and end twice when participates in gesture arena - #82152

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
nt4f04uNd:slider
May 20, 2021
Merged

Fix slider notifies start and end twice when participates in gesture arena#82152
fluttergithubbot merged 2 commits into
flutter:masterfrom
nt4f04uNd:slider

Conversation

@nt4f04uNd

@nt4f04uNd nt4f04uNd commented May 9, 2021

Copy link
Copy Markdown
Member

Fixes #28115

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels May 9, 2021
@google-cla google-cla Bot added the cla: yes label May 9, 2021
@nt4f04uNd nt4f04uNd mentioned this pull request May 9, 2021
Closed
8 tasks
goderbauer
goderbauer approved these changes May 20, 2021
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 0902576 into flutter:master May 20, 2021
@nt4f04uNd
nt4f04uNd deleted the slider branch May 20, 2021 23:44
@nt4f04uNd nt4f04uNd mentioned this pull request May 21, 2021
Closed
@WieFel

WieFel commented May 26, 2021

Copy link
Copy Markdown

When will this land in stable channel?

@nt4f04uNd nt4f04uNd mentioned this pull request Jun 11, 2023
Merged
8 tasks done
auto-submit Bot pushed a commit that referenced this pull request Jun 12, 2023
@nt4f04uNd
Fix RangeSlider notifies start and end twice when participates in ges…
ad8c997 
…ture arena (#128674)

Fixes #128433

This PR applies the same fix as we did for Slider #82152
chunhtai pushed a commit to chunhtai/packages that referenced this pull request Jun 12, 2026
@nt4f04uNd
Fix RangeSlider notifies start and end twice when participates in ges…
e353dfb 
…ture arena (#128674)

Fixes flutter/flutter#128433

This PR applies the same fix as we did for Slider flutter/flutter#82152
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Slider notifies "onChangeEnd" twice when it is over a InkWell/GestureDetector

4 participants

@nt4f04uNd @WieFel @goderbauer @fluttergithubbot