Skip to content

Add coldboot parameter to JSON-RPC interface of daemon - #83488

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
Hamdor:add_cold_boot_launch_json_rpc
May 28, 2021
Merged

Add coldboot parameter to JSON-RPC interface of daemon#83488
fluttergithubbot merged 1 commit into
flutter:masterfrom
Hamdor:add_cold_boot_launch_json_rpc

Conversation

@Hamdor

@Hamdor Hamdor commented May 27, 2021

Copy link
Copy Markdown
Contributor

The coldboot parameter can be used for android based emulators to
force a full boot.

The JSON-RPC interface does not provide means to cold boot android based emulators. This option was recently added using the command line interface. This pull request extends the JSON-RPC interface for cold boot launch.

Note: This PR changes the version of the daemon from 0.6.0 to 0.6.1, the change is fully backwards compatible.

This PR implements the following feature request #83471

closes #83471

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added the tool Affects the "flutter" command-line tool. See also t: labels. label May 27, 2021
@google-cla google-cla Bot added the cla: yes label May 27, 2021
@Hamdor

Hamdor commented May 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

One thing that should be considered: I did not find any good case tests for the flutter daemon. Please tell me where I can find them to extend it if necessary.

@Hamdor
Hamdor force-pushed the add_cold_boot_launch_json_rpc branch from 1b706a2 to 053bad0 Compare May 27, 2021 15:54
blasten
blasten reviewed May 27, 2021
View reviewed changes
Comment thread packages/flutter_tools/tool/daemon_client.dart Outdated

@blasten blasten May 27, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is launch the same as emulator-launch?

@jonahwilliams can this break something?

@Hamdor Hamdor May 27, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed that because its either here wrong or at line 19. I can of course change it back if wanted

@jonahwilliams jonahwilliams May 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @DanTup , not sure if this is used

@DanTup DanTup May 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think line 19 (the comment) is probably wrong - it's probably better that this is more explicit (and changing the comment doesn't change behaviour). My understanding is that this is a simple CLI tool to manually interact with the daemon (for debugging/testing purposes).

DanTup
DanTup reviewed May 27, 2021
View reviewed changes
Comment thread packages/flutter_tools/doc/daemon.md Outdated

@DanTup DanTup May 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be more consistent as coldBoot?

@Hamdor Hamdor May 27, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, I will change that

DanTup
DanTup reviewed May 27, 2021
View reviewed changes
Comment thread packages/flutter_tools/lib/src/commands/daemon.dart Outdated

@DanTup DanTup May 27, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think required: false is unnecessary.

@Hamdor
Add coldBoot parameter to JSON-RPC interface of daemon
dbc72d6 
The `coldBoot` parameter can be used for android based emulators to
force a full boot.
@Hamdor
Hamdor force-pushed the add_cold_boot_launch_json_rpc branch from 053bad0 to dbc72d6 Compare May 28, 2021 05:24
@Hamdor

Hamdor commented May 28, 2021

Copy link
Copy Markdown
Contributor Author

The latest commit contains the requested changes

jonahwilliams
jonahwilliams approved these changes May 28, 2021
View reviewed changes

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit 722a493 into flutter:master May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DanTup DanTup DanTup left review comments
+2 more reviewers
@blasten blasten blasten left review comments
@jonahwilliams jonahwilliams jonahwilliams approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add cold boot launch option to flutter daemon

5 participants

@Hamdor @DanTup @blasten @jonahwilliams @fluttergithubbot