Repository navigation
Add a "troubleshooting" section to the AppBar API doc - #86188
Conversation
flutter-dashboard
Bot
added
p: material_ui
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
darrenaustin
left a comment
darrenaustin
left a comment
There was a problem hiding this comment.
LGTM. I'm probably missing something, but would it make sense to have the AppBar wrap the children in a button theme that does this by default, or is that too fraught with problems for cases that don't want this?
|
Yes it would but:
It turns out that many existing components and apps, including DatePicker, don't work with the original remedy. |
|
test-exempt: only affects comments |
3 participants
Document how to style TextButtons so that their foreground color contrasts well with the AppBar's default background color.
The original remedy, #84642 (comment), turned out to be impractical. Documenting the work-around instead.
Fixes #84642