Skip to content

Remove unused build_mode_test - #86808

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:build-mode
Jul 21, 2021
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
jmagman:build-mode

Conversation

@jmagman

@jmagman jmagman commented Jul 21, 2021

Copy link
Copy Markdown
Member

--dynamic flag was introduced in #20543 and removed in #34736. Test was introduced in #27502.

Part of auditing devicelab tasks: #86802

@jmagman jmagman added a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. labels Jul 21, 2021
@jmagman jmagman self-assigned this Jul 21, 2021
@google-cla google-cla Bot added the cla: yes label Jul 21, 2021
@jmagman jmagman mentioned this pull request Jul 21, 2021
21 of 22 tasks
await tester.pumpAndSettle();

expect(find.text('Hello, world!'), findsOneWidget);
expect(find.byType(SizedBox), findsOneWidget);

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked another entry point for this smoke test so build_mode could be deleted.

@jmagman
jmagman requested a review from jonahwilliams July 21, 2021 22:55

@jonahwilliams jonahwilliams left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot
fluttergithubbot merged commit f50e231 into flutter:master Jul 21, 2021
@jmagman
jmagman deleted the build-mode branch July 21, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants