Repository navigation
Devicelab task tests not running anywhere #86802
Description
These dev/devicelab/bin/tasks are not present in .ci.yaml. Are they running anywhere?
Missed during CI config migrations, needs builder
- animation_with_microtasks_perf_ios__timeline_summary - introduced in Add a test to exercise multiple async microtasks in frame workload #79163
- fullscreen_textfield_perf - introduced in macrobenchmark: active TextField with complex paragraph #73374
- fullscreen_textfield_perf__e2e_summary - introduced in macrobenchmark: active TextField with complex paragraph #73374
- plugin_test_ios (plugin_tests_ios devicelab task test is not running anywhere #86801) - introduced in Move plugin injection to just after pub get #14560
Should be turned on, needs builder
- android_engine_dependency_proxy_test - introduced in let the embedding maven engine dependency reference the storage proxy #56164, never turned on?
- devtools_profile_start_test - introduced in [flutter] ensure vmservice binding is registered in profile mode #83913, never turned on?
- gradle_java8_compile_test - introduced in Standardize how Java8 is set in gradle files #80600, never turned on? Add entries in ci for
plugin_dependencies_testandgradle_java8_compile_test#86904 - plugin_dependencies_test - mistakenly removed in [devicelab] turn down android X migration gradle tests #68110, should be run on Linux, macOS, and Windows. Host only. Add entries in ci for
plugin_dependencies_testandgradle_java8_compile_test#86904
Purposely turned off, should be removed
- build_aar_plugin_test - turned off in Roll back the AAR build experiment #36966, Remove AndroidX compatibility workarounds #86911
- build_mode_test - Remove unused build_mode_test #86808
- flutter_gallery_instrumentation_test - Remove unused flutter_gallery_instrumentation_test #86812
- flutter_run_test - introduced in Run flutter tests through mini test engine when run directly (flutter run -t test_file) #24930, turned in try disabling flutter run test #25416, Remove unused flutter_run_test #86828
- gradle_migrate_settings_test - turned off in Roll back the AAR build experiment #36966, Remove AndroidX compatibility workarounds #86911
- textfield_perf - reimplemented as
textfield_perf__timeline_summary, Remove obsolete textfield_perf test #86827 - web_incremental_test - turned off in Remove chrome device web integration test #44746, Remove unused web_incremental_test #86829
Obsolete, should be removed
- codegen_integration_* - feature removed in [flutter_tools] deprecate flutter generate and codegen #58328, Remove obsolete codegen_integration tests #86962
- plugin_test_win - can be deleted, covered by
Windows plugin_test, Remove obsolete plugin_test_win #86826 - tiles_scroll_perf_iphonexs__timeline_summary - Remove unused tiles_scroll_perf_iphonexs__timeline_summary #86822
Should stay off
- gradle_non_android_plugin_test - removal tracked with Remove gradle_non_android_plugin_test test and builder when no longer needed in stable #85347
- hot_mode_dev_cycle_linux_target__benchmark - introduced in Add hot reload test tasks for Linux and Windows desktop #73889, to be turned on with [devicelab][desktop] Add Linux and Windows machines #54295
- hot_mode_dev_cycle_win_target__benchmark - introduced in Add hot reload test tasks for Linux and Windows desktop #73889, to be turned on with [devicelab][desktop] Add Linux and Windows machines #54295
Unknown
Add test owners for any tests that are turned on.
Activity
zanderso commentedon Jul 21, 2021
@iskakaushik FYI on https://github.com/flutter/flutter/blob/master/dev/devicelab/bin/tasks/animation_with_microtasks_perf_ios__timeline_summary.dart
keyonghan commentedon Jul 21, 2021
Is this for Linux, Mac, or Windows? I assume this needs an android phone? @xster
Is this for Linux, Mac, or Windows? Is this a host only test? @jonahwilliams
Is this for Linux, Mac, or Windows? Is this a host only test? @blasten
blasten commentedon Jul 21, 2021
Host only - Linux. Thanks!
jmagman commentedon Jul 21, 2021
@blasten can you also advise for this one? I'm guessing just Linux, and it looks host only? Optionally it could be re-written as a
flutter_toolintegration test instead of using the devicelab.jmagman commentedon Jul 22, 2021
@blasten Do you have more context for these two? From #36966 I can't tell if they were only temporarily turned off to fix a transient plugins repo problem, or maybe were waiting for a tool feature to make it into stable? Should these be fixed up and reenabled, or should they be deleted?
blasten commentedon Jul 22, 2021
@jmagman actually, those tests can be removed, no needed/no value added.
blasten commentedon Jul 22, 2021
I can send a PR to remove them in a bit
jonahwilliams commentedon Jul 22, 2021
codegen_integration_x can be removed, the feature has been deleted
jmagman commentedon Jul 23, 2021
@keyonghan Just Linux, needs a real device.
iskakaushik commentedon Jul 30, 2021
animation_with_microtasks_perf_ios__timeline_summaryhas been added to post-submits in #87345.jmagman commentedon Jul 30, 2021
Awesome, will check it off once
bringupis removed.jmagman commentedon Aug 17, 2021
Almost there!
@zanderso @flutter/engine)@zanderso @flutter/engine)@stuartmorgan @flutter/plugin)@keyonghan can you add the builders for these too?
@blasten for
android_engine_dependency_proxy_testI'm guessing just Linux, and it looks host only? Who should be the test owner?keyonghan commentedon Aug 19, 2021
https://flutter-review.googlesource.com/c/infra/+/17180 to add
https://flutter-review.googlesource.com/c/infra/+/17180 to add them to staging. Will enable in prod once validated not flaky.
godofredoc commentedon Nov 16, 2022
@jmagman @keyonghan can we close this bug?
jmagman commentedon Nov 16, 2022
android_engine_dependency_proxy_test and flutter_attach_test_fuchsia still aren't running anywhere.
It looks like android_engine_dependency_proxy_test needs a builder and needs to be turned on.
@zanderso can we delete flutter_attach_test_fuchsia?
zanderso commentedon Nov 16, 2022
If
fuchsia_attach_testhasn't been running for over a year, and no one has noticed, then it should probably be deleted.godofredoc commentedon Nov 16, 2022
https://flutter-review.googlesource.com/c/recipes/+/36380 for removing the modules and recipes that haven't been used for over a year.
github-actions commentedon Mar 31, 2023
This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of
flutter doctor -vand a minimal reproduction of the issue.