Repository navigation
Deprecate ThemeData.fixTextFieldOutlineLabel - #87281
Conversation
flutter-dashboard
Bot
added
p: material_ui
|
Gold has detected about 4 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. Changes reported for pull request #87281 at sha 05c21d71165cd8b36b5f196753cbc3197f94d35f |
|
This change should also include a dart fix since it is deprecating something. |
05c21d7 to
601aa44
Compare
|
Gold has detected about 8 new digest(s) on patchset 2. |
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Thanks for writing a fix! :)
The deprecation period has elapsed. The method was made obsolete in #87281.
The deprecation period has elapsed. The method was made obsolete in flutter#87281.
The deprecation period has elapsed. The method was made obsolete in flutter/flutter#87281.
The deprecation period has elapsed. The method was made obsolete in flutter/flutter#87281.
3 participants
Deprecates what was supposed to have been a temporary flag:
ThemeData.fixTextFieldOutlineLabel. The flag's value is now true by default and now the InputDecorator's floating label is vertically centered instead of being slightly too low.Old - ThemeData.fixTextFieldOutlineLabel = false
New - ThemeData.fixTextFieldOutlineLabel = true
Fixes #87224