Repository navigation
Updated skipped tests for painting directory. - #87546
Conversation
flutter-dashboard
Bot
added
the
framework
darrenaustin
added
team: skip-test
|
Gold has detected about 5 new digest(s) on patchset 1. |
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
| // we were consistently considering them part of words always. | ||
| final TextRange hebrew1 = painter.getWordBoundary(const TextPosition(offset: 4, affinity: TextAffinity.downstream)); | ||
| expect(hebrew1, const TextRange(start: 0, end: 8), skip: skipExpectsWithKnownBugs); | ||
| expect(hebrew1, const TextRange(start: 0, end: 8), skip: skipExpectsWithKnownBugs); // https://github.com/flutter/flutter/issues/87536 |
There was a problem hiding this comment.
Should this annotation just be on the skipExpectsWithKnownBugs constant?
There was a problem hiding this comment.
That would make it harder for the analyzer script to detect it. Right now I am think it would just use a simple regexp looking for the skip param with a comment on the same line.
3 participants
Part of #86396.
Updated the skip tests in the 'painting' directory. Turned some tests back on, marked some as intentional in a comment or added issues where missing.