Skip to content

Updated skipped tests for widgets directory. - #87879

Merged
darrenaustin merged 1 commit into
flutter:masterfrom
darrenaustin:skip_widgets
Aug 9, 2021
Merged

darrenaustin merged 1 commit into
flutter:masterfrom
darrenaustin:skip_widgets

Conversation

@darrenaustin

Copy link
Copy Markdown
Contributor

Part of #86396.

Updated the skip tests in the 'widgets' directory. Turned some tests back on, marked some as intentional in a comment or added issues where missing.

@darrenaustin darrenaustin added c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. team: skip-test An issue used to track tests that are skipped. labels Aug 7, 2021
@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 7, 2021
@google-cla google-cla Bot added the cla: yes label Aug 7, 2021
@darrenaustin darrenaustin mentioned this pull request Aug 7, 2021
17 tasks done
@skia-gold

Copy link
Copy Markdown

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/87879

1 similar comment
@skia-gold

Copy link
Copy Markdown

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/87879

@flutter-dashboard

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #87879 at sha c501e3f89ea6a375a8de16875c39f867754acaf6

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label Aug 9, 2021
@skia-gold

Copy link
Copy Markdown

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/87879

@flutter-dashboard

Copy link
Copy Markdown

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #87879 at sha 55c6f22

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Piinks

Piinks commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

Gold changes should be ignored here. Gold sometimes gets confused when the git history is overwritten. I have triaged the images as negative. I do not know if the check will clear (this has only happened once before). I'll wait and see (~5 minutes is when it updates the check).

@Piinks

Piinks commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

Checks cleared! @darrenaustin is this ready to land then?

@darrenaustin
darrenaustin merged commit e2fb5cc into flutter:master Aug 9, 2021
@darrenaustin
darrenaustin deleted the skip_widgets branch August 9, 2021 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. c: tech-debt Technical debt, code quality, testing, etc. framework flutter/packages/flutter repository. See also f: labels. team: skip-test An issue used to track tests that are skipped. will affect goldens Changes to golden files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants