Repository navigation
Prepare the flutter.material.RawMaterialButton.mouseCursor doc template for themeable mouse cursors - #88470
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
Bot
added
p: material_ui
|
IconButton.mouseCursor docs:
|
|
test-exempt: only affects comments |
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
This is OK however RawMaterialButton isn't really used much any more. It would be better to adjust the InkWell.mouseCursor API doc, make that the template, and replace {@macro flutter.material.RawMaterialButton.mouseCursor} with {@macro flutter.material.InkWell.mouseCursor}
|
Thanks for the suggestion (and for taking care of the other mouse cursor changes). There's one important difference between /// The cursor for a mouse pointer when it enters or is hovering over the
-/// button.
+/// widget.
///
/// If [mouseCursor] is a [MaterialStateProperty<MouseCursor>],
/// [MaterialStateProperty.resolve] is used for the following [MaterialState]s:
///
-/// * [MaterialState.pressed].
/// * [MaterialState.hovered].
/// * [MaterialState.focused].
/// * [MaterialState.disabled]. |
|
This pull request is not suitable for automatic merging in its current state.
|
5 participants
Prepare the docs for themeable mouse cursors by moving
outside the template, because when adding themeable mouse cursors, the description changes to something like:
Coincidentally, this also fixes IconButton.mouseCursor docs that ended up having duplicate defaults in #63885.
Related issues
Motivated by themeable mouse cursors: #88371
Fixes IconButton.mouseCursor docs: #63885
Pre-launch Checklist
///).