Skip to content

partial revert of gesture config - #88534

Merged
jonahwilliams merged 4 commits into
flutter:masterfrom
jonahwilliams:partial_revert_scroll_config
Aug 20, 2021
Merged

partial revert of gesture config#88534
jonahwilliams merged 4 commits into
flutter:masterfrom
jonahwilliams:partial_revert_scroll_config

Conversation

@jonahwilliams

@jonahwilliams jonahwilliams commented Aug 19, 2021

Copy link
Copy Markdown
Contributor

Unblocks internal roll

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Aug 19, 2021
@flutter-dashboard

flutter-dashboard Bot commented Aug 19, 2021

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@google-cla google-cla Bot added the cla: yes label Aug 19, 2021
@jonahwilliams

jonahwilliams commented Aug 19, 2021

Copy link
Copy Markdown
Contributor Author

FYI @renyou @zanderso

@zanderso

zanderso commented Aug 19, 2021

Copy link
Copy Markdown
Member

I pushed some ';'s

@zanderso

zanderso commented Aug 19, 2021

Copy link
Copy Markdown
Member

Since this is for unblocking the internal roll, this can land over the tree-closure.

@renyou

renyou commented Aug 20, 2021

Copy link
Copy Markdown
Contributor

@jonahwilliams Is this PR ready to be merged?

@jonahwilliams

jonahwilliams commented Aug 20, 2021

Copy link
Copy Markdown
Contributor Author

Getting it ready now, sorry - notifications + email were getting DDOS'd by issue closed notifications

@jonahwilliams
jonahwilliams merged commit 01d0c53 into flutter:master Aug 20, 2021
@jonahwilliams
jonahwilliams deleted the partial_revert_scroll_config branch August 20, 2021 20:43
renyou pushed a commit to renyou/flutter that referenced this pull request Aug 20, 2021
Jonah Williams @zanderso @renyou
partial revert of gesture config (flutter#88534)
6f899c6 
Co-authored-by: Zachary Anderson <[email protected]>
renyou added a commit that referenced this pull request Aug 21, 2021
@renyou Jonah Williams @zanderso
partial revert of gesture config (#88534) (#88608)
db64aed 
* partial revert of gesture config (#88534)


Co-authored-by: Zachary Anderson <[email protected]>

* Update ci.yaml to enable the tests

Co-authored-by: Jonah Williams <[email protected]>
Co-authored-by: Zachary Anderson <[email protected]>
@jonahwilliams jonahwilliams mentioned this pull request Aug 23, 2021
Closed
@jonahwilliams jonahwilliams mentioned this pull request Feb 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @zanderso @renyou