Skip to content

Enable Mac plugin_test_ios in prod - #91713

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
keyonghan:plugin_test_ios_prod
Oct 13, 2021
Merged

fluttergithubbot merged 2 commits into
flutter:masterfrom
keyonghan:plugin_test_ios_prod

Conversation

@keyonghan

Copy link
Copy Markdown
Contributor

See #88794

@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Comment thread .ci.yaml
- bin/**
- .ci.yaml

- name: Mac plugin_test_ios

@keyonghan keyonghan Oct 12, 2021 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmagman who should be the owner of this test?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me, please!

@jmagman jmagman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @keyonghan!

@fluttergithubbot
fluttergithubbot merged commit 68f2143 into flutter:master Oct 13, 2021
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@keyonghan
keyonghan deleted the plugin_test_ios_prod branch April 25, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants