Skip to content

Run flutter tester with arch -x86_64 on arm64 Mac - #92508

Merged
fluttergithubbot merged 2 commits into
flutter:masterfrom
jmagman:test-device-arm
Oct 27, 2021
Merged

Run flutter tester with arch -x86_64 on arm64 Mac#92508
fluttergithubbot merged 2 commits into
flutter:masterfrom
jmagman:test-device-arm

Conversation

@jmagman

@jmagman jmagman commented Oct 26, 2021

Copy link
Copy Markdown
Member

On ARM Macs, run the flutter_tester process with arch -x86_64. It's already running in Rosetta, but we've had reports that this process fails with rosetta error: unexpectedly got a signal in sigtramp unless it's run with arch -x86_64. I don't really understand why, except that it's some Rosetta bug.

Fixes #88106

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I signed the [CLA].
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is [test-exempt].
  • All existing and new tests are passing.

@jmagman jmagman added tool Affects the "flutter" command-line tool. See also t: labels. platform-macos Building on or for macOS specifically platform-host-arm Building on an ARM-based platform labels Oct 26, 2021
@jmagman jmagman self-assigned this Oct 26, 2021
@google-cla google-cla Bot added the cla: yes label Oct 26, 2021
@jmagman jmagman mentioned this pull request Oct 26, 2021
Closed
zanderso
zanderso reviewed Oct 26, 2021
View reviewed changes
Comment thread packages/flutter_tools/lib/src/test/flutter_tester_device.dart Outdated

@zanderso zanderso Oct 26, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider linking to the github issue here.

@fluttergithubbot
fluttergithubbot merged commit b279ff4 into flutter:master Oct 27, 2021
@jmagman
jmagman deleted the test-device-arm branch October 27, 2021 19:17
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Oct 29, 2021
@jmagman @clocksmith
Run flutter tester with arch -x86_64 on arm64 Mac (flutter#92508)
852cecb
WizzXu pushed a commit to WizzXu/flutter that referenced this pull request Nov 19, 2021
@jmagman @WizzXu
Run flutter tester with arch -x86_64 on arm64 Mac (flutter#92508)
ab69311
@jmagman jmagman mentioned this pull request Feb 18, 2022
Closed
@doc-rj-ebay

doc-rj-ebay commented Aug 31, 2022

Copy link
Copy Markdown

Just a note -- it only fails when running with --coverage

@jmagman

jmagman commented Aug 31, 2022

Copy link
Copy Markdown
Member Author

@doc-rj-ebay can you try on master? The arm version available there.

@doc-rj-ebay

doc-rj-ebay commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown

@doc-rj-ebay can you try on master? The arm version available there.

Thanks @jmagman and sorry, it was this other --coverage issue that I was experiencing: #103656

@jmagman Do you know if that issue is fixed in dart 2.18 (stable)?

@jmagman

jmagman commented Aug 31, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

@jmagman Do you know if that issue is fixed in stable?

If you were hitting #103656 that was fixed in https://dart.googlesource.com/sdk/+/539cccd8234ee10fddca244d9855ce0e0e5d8c45 which is in flutter-team-archive/engine#33528 is in #104316 which is in Flutter 3.3, released yesterday. If you are still seeing issues, please file them!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

@jmagman jmagman

Labels

platform-host-arm Building on an ARM-based platform platform-macos Building on or for macOS specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

flutter test --coverage often fails on M1 "hell: rosetta error: unexpectedly got a signal in sigtramp"

4 participants

@jmagman @doc-rj-ebay @zanderso @fluttergithubbot