Repository navigation
Manually roll the engine and update Gradle dependency locks - #92800
Conversation
flutter-dashboard
Bot
added
a: accessibility
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
Is this the fix for #92801? |
|
Yup |
dnfield
left a comment
dnfield
left a comment
There was a problem hiding this comment.
Lgtm to unblock the roll
We should have a way to do this without requiring manual steps.
|
Was this a breaking change? Are end-users going to have to take any action to compensate for the updated engine deps? |
|
Apologies, I did not know about this, thanks @blasten! |
|
I think only if they're using lock files in a similar way. @blasten would know better |
|
No. This isn’t not a braking change. The lockfiles are used to keep the deterministic Gradle dependencies during CI execution. |
|
@angjieli is kicking the internal test run, which should hopefully turn the "Google testing" run green. |
4 participants
This is required whenever the embedding dependencies are changed.
To update the dependencies in the future, use:
find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dartSubsumes this auto-roll: #92794