Repository navigation

Deprecate `useDeleteButtonTooltip` for Chips - #96174

Merged

fluttergithubbot merged 8 commits into

flutter:masterfrom

royarg02:deprecate-chip-delete-tooltip

Jan 28, 2022

Merged

Deprecate `useDeleteButtonTooltip` for Chips#96174
fluttergithubbot merged 8 commits into
flutter:masterfrom
royarg02:deprecate-chip-delete-tooltip

royarg02 commented Jan 5, 2022 •

edited

Loading

Contributor

This PR deprecates useDeleteButtonTooltip, for Chip widgets that support having a delete button. This includes the Chip, the InputChip and the RawChip widget.

Instead, to disable the tooltips on the delete button of these chips, users should pass an empty string to deleteButtonTooltipMessage.

A dart fix is provided.

The migration code is shown below:

Before:

Chip(useDeleteButtonTooltip: false);
InputChip(useDeleteButtonTooltip: true);
RawChip rawChip = RawChip();
rawChip.useDeleteButtonTooltip;

After:

Chip(deleteButtonTooltipMessage: ‘’);
InputChip();
RawChip rawChip = RawChip();
rawChip.deleteButtonTooltipMessage;

The design doc for this change can be found here.

This is not a breaking change as it is only deprecating a property.

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard Bot added p: material_ui framework c: contributor-productivity c: tech-debt labels

royarg02 commented

View reviewed changes

packages/flutter/lib/fix_data.yaml Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/fix_data.yaml Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/fix_data.yaml Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/fix_data.yaml Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/fix_data.yaml Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/fix_data.yaml Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/lib/src/material/chip.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/test_fixes/material.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/test_fixes/material.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/test_fixes/material.dart Outdated

royarg02 commented

View reviewed changes

packages/flutter/test_fixes/material.dart.expect Outdated

royarg02 commented

View reviewed changes

packages/flutter/test_fixes/material.dart.expect Outdated

royarg02 commented

View reviewed changes

packages/flutter/test_fixes/material.dart.expect Outdated

royarg02 added a commit to royarg02/website that referenced this pull request


          Add design doc go link for deprecating useDeleteButtonTooltip for Chips

100ff75

Context: flutter/flutter#96174

royarg02 mentioned this pull request

Add go/chip-usedeletebuttontooltip-deprecation flutter/website#6635

Merged

3 tasks done

royarg02 changed the title ~~[WIP] Deprecate useDeleteButtonTooltip for Chips~~ Deprecate useDeleteButtonTooltip for Chips

royarg02 commented Jan 6, 2022 •

edited

Loading

Contributor Author

@gspencergoog The PR is (mostly) ready for review, I just have a few concerns:
~~1. Since dev channel is deprecated, what version should I provide for the deprecation notices?~~
2. I updated some comments and a test for delete button tooltip, which I committed here royarg02@bf86261. If it looks good to you, I'll submit a separate PR.

khanhnwin pushed a commit to flutter/website that referenced this pull request


          Add design doc go link for deprecating useDeleteButtonTooltip for Chi…

a9c4f95

…ps (#6635)

Context: flutter/flutter#96174

HansMuller requested a review from Piinks

January 7, 2022 23:47

Piinks reviewed

View reviewed changes

Piinks left a comment

Contributor

Woohoo! Thanks for writing a dart fix! 💯
For the deprecation version, update with the latest from the master branch, and then use the version from flutter doctor.

Hixie approved these changes

View reviewed changes

Hixie left a comment

Contributor

Hixie commented Jan 26, 2022

Contributor

Looks like there are some conflicts to resolve before it can land, unfortunately.

royarg02 force-pushed the deprecate-chip-delete-tooltip branch 2 times, most recently from 016e03b to e81a90c Compare

January 27, 2022 20:23

Piinks added the waiting for tree to go green label

fluttergithubbot commented Jan 27, 2022

Contributor

This pull request is not suitable for automatic merging in its current state.

The status or check suite Windows framework_tests_misc has failed. Please fix the issues identified (or deflake) before re-applying this label.

fluttergithubbot removed the waiting for tree to go green label

royarg02 added 8 commits

January 28, 2022 09:30


          [WIP] Deprecate useDeleteButtonTooltip for Chips

fc95ec5


          Update flutter fixes

8d88554


          Update

6dbb529


          Update PR link and fix date

63a4e5c


          Add deprecation version

c8df3f4


          Specify "empty" as "an empty string" in docs

d3dbdc6


          Update deprecation version to beta

13976ff


          Change deprecation message

0fb626c

royarg02 force-pushed the deprecate-chip-delete-tooltip branch from e81a90c to 0fb626c Compare

January 28, 2022 04:02

werainkhatri added the waiting for tree to go green label

fluttergithubbot merged commit 4621dff into flutter:master

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4621dff Deprecate useDeleteButtonTooltip for Chips (flutter/flutter…

374450b

…#96174)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from e854b8cc889f to 4621dff89243 (1 revision) flutter/packages#578

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request


          4621dff Deprecate useDeleteButtonTooltip for Chips (flutter/flutter…

ad6a159

…#96174)

engine-flutter-autoroll mentioned this pull request

Roll Flutter from e854b8cc889f to 4621dff89243 (1 revision) flutter/packages#579

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request


          4621dff Deprecate useDeleteButtonTooltip for Chips (flutter/flutter…

a493526

…#96174)

royarg02 mentioned this pull request

Add migration guide for deprecating useDeleteButtonTooltip of chips flutter/website#6823

Merged

3 tasks done

royarg02 deleted the deprecate-chip-delete-tooltip branch

March 6, 2022 07:08

clocksmith pushed a commit to clocksmith/flutter that referenced this pull request


          Deprecate useDeleteButtonTooltip for Chips (flutter#96174)

6aae111

Piinks mentioned this pull request

Deprecate old accept callbacks in DragTarget #133347

Closed

Piinks mentioned this pull request

Remove chip tooltip deprecations #134486

Merged

7 of 8 tasks

auto-submit Bot pushed a commit that referenced this pull request


          Remove chip tooltip deprecations (#134486)

4e7a07a

Part of #133171

These deprecations were introduced in #96174
The replacement is to use `deleteButtonTooltipMessage`.
This migration is supported by dart fix. â�

chunhtai pushed a commit to chunhtai/packages that referenced this pull request


          Remove chip tooltip deprecations (#134486)

8104b0b

Part of flutter/flutter#133171

These deprecations were introduced in flutter/flutter#96174
The replacement is to use `deleteButtonTooltipMessage`.
This migration is supported by dart fix. â�

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity c: tech-debt framework p: material_ui