Skip to content

Include Dart SDK arch in package info - #97278

Merged
zanderso merged 1 commit into
flutter:masterfrom
zanderso:package-arch-info
Feb 2, 2022
Merged

zanderso merged 1 commit into
flutter:masterfrom
zanderso:package-arch-info

Conversation

@zanderso

Copy link
Copy Markdown
Member

This PR adds a dart_sdk_arch field to the description of a release bundle. This field describes the target arch of the bundled Dart SDK. For non-x64 architectures, this arch string is also included in the filename of the release bundle.

@zanderso

Copy link
Copy Markdown
Member Author

@christopherfujino Is there any way to test this by packaging a commit on master?

@goderbauer goderbauer added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team labels Jan 26, 2022
@zanderso

Copy link
Copy Markdown
Member Author

Here's a website PR to go along with this one that displays the information flutter/website#6736

@zanderso

Copy link
Copy Markdown
Member Author

I added unit tests and enabled local testing with commits on master by disabling 'strict' mode when the --dry-run flag is passed. This change is ready for review.

@christopherfujino

Copy link
Copy Markdown
Contributor

@christopherfujino Is there any way to test this by packaging a commit on master?

I'd have to look at a recipe, but if you run it in led it might upload it to an experimental (unused) storage bucket, where you can then download it and verify that the contents are correct.

This change looks good, but it is blocked by #97536

Comment thread dev/bots/prepare_package.dart Outdated
Comment thread dev/bots/prepare_package.dart Outdated
Comment thread dev/bots/prepare_package.dart Outdated

@christopherfujino christopherfujino left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zanderso
zanderso merged commit 219bcd3 into flutter:master Feb 2, 2022
@zanderso
zanderso deleted the package-arch-info branch February 2, 2022 17:02
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 2, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants