Skip to content

Update SliverChildDelegate docs - #97674

Merged
fluttergithubbot merged 3 commits into
flutter:masterfrom
Piinks:delegateDocs
Feb 3, 2022
Merged

fluttergithubbot merged 3 commits into
flutter:masterfrom
Piinks:delegateDocs

Conversation

@Piinks

@Piinks Piinks commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

Fixes #95028

This adds documentation to SliverChildDelegate (and subclasses SliverChildListDelegate and SliverChildBuilderDelegate by way of template) that using more than one delegate in a scroll view expects to see at least a single child built for each so that the scroll offset can be estimated for the entire viewport.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels. labels Feb 2, 2022
@Piinks Piinks added d: api docs Issues with https://api.flutter.dev/ documentation labels Feb 2, 2022

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/flutter/lib/src/widgets/sliver.dart
@fluttergithubbot
fluttergithubbot merged commit c045a07 into flutter:master Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 3, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 4, 2022
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

d: api docs Issues with https://api.flutter.dev/ f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple SliverChildBuilderDelegates always build the first child

3 participants