Skip to content

Update default ThemeData.textTheme styles to Material 3 typography - #97829

Merged
fluttergithubbot merged 4 commits into
flutter:masterfrom
darrenaustin:m3_typography
Feb 8, 2022
Merged

Update default ThemeData.textTheme styles to Material 3 typography#97829
fluttergithubbot merged 4 commits into
flutter:masterfrom
darrenaustin:m3_typography

Conversation

@darrenaustin

@darrenaustin darrenaustin commented Feb 4, 2022 •
edited by guidezpl
Loading

Copy link
Copy Markdown
Contributor

As part of the Material 3 migration, this PR adds support for the M3 typography text styles and themes:

Typography

This adds a new Typography constructor: Typography.material2021 that will provide a set of text themes that match the Material 3 spec.

Also if a ThemeData is constructed without specifying the typography parameter and useMaterial3 is true, it will use Typography.material2021. Otherwise, it will use the usual default of Typography.material2014.

New tests were added to check the values of the new text themes as well as the useMaterial3 settings.

This addresses part of #89853 (fixes #89853).

@flutter-dashboard flutter-dashboard Bot added p: material_ui material_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Feb 4, 2022
guidezpl
guidezpl approved these changes Feb 7, 2022
View reviewed changes

@guidezpl guidezpl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

  _    ___ _____ __  __ 
 | |  / __|_   _|  \/  |
 | |_| (_ | | | | |\/| |
 |____\___| |_| |_|  |_|

HansMuller
HansMuller approved these changes Feb 7, 2022
View reviewed changes

@HansMuller HansMuller left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rami-a
rami-a approved these changes Feb 7, 2022
View reviewed changes
Comment thread packages/flutter/lib/src/material/typography.dart Outdated
@fluttergithubbot
fluttergithubbot merged commit 93a1b7a into flutter:master Feb 8, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
e8c991e
@darrenaustin
darrenaustin deleted the m3_typography branch February 8, 2022 01:12
@darrenaustin darrenaustin mentioned this pull request Feb 8, 2022
Closed
4 tasks done
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
73841f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
d13b62c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
059fa30
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
84f32c2
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
b782760
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 8, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
d5bdb93
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
ca245f0
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
13c279e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
a62bf81
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
61fecf3
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
1104276
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
480248d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
f1800fe
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
761ff85
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
9afd90c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
574b338
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
6a86de7
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 9, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 9, 2022
@engine-flutter-autoroll
93a1b7a Material 3 Typography support. (flutter/flutter#97829)
8500956
@darrenaustin darrenaustin mentioned this pull request Feb 23, 2022
Closed
63 of 70 tasks
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
@darrenaustin @clocksmith
Material 3 Typography support. (flutter#97829)
62f0f00
@guidezpl guidezpl changed the title Material 3 Typography support. Update default ThemeData.textTheme styles to Material 3 typography Mar 30, 2022
@rydmike rydmike mentioned this pull request May 3, 2022
Closed
@htsuruo htsuruo mentioned this pull request Nov 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@guidezpl guidezpl guidezpl approved these changes
+2 more reviewers
@HansMuller HansMuller HansMuller approved these changes
@rami-a rami-a rami-a approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. framework flutter/packages/flutter repository. See also f: labels. p: material_ui material_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

☂️ Update TextTheme to use new Material 3 text styles

5 participants

@darrenaustin @HansMuller @rami-a @guidezpl @fluttergithubbot