Skip to content

Add a BindingBase.debugBindingType() method to enable asserts that want to verify that the binding isn't initialized - #98226

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
Hixie:binding_type
Feb 11, 2022
Merged

fluttergithubbot merged 1 commit into
flutter:masterfrom
Hixie:binding_type

Conversation

@Hixie

@Hixie Hixie commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

No description provided.

@flutter-dashboard flutter-dashboard Bot added the framework flutter/packages/flutter repository. See also f: labels. label Feb 11, 2022

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: in -> it

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Document that calling this is only valid in debug mode and will return null in non-debug mode even when the bindings are initialized?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yikes, good call, i totally forgot to mention that

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lint is complaining about initializing this to null.

…nt to verify that the binding isn't initialized
@fluttergithubbot
fluttergithubbot merged commit fce2f93 into flutter:master Feb 11, 2022
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Feb 11, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Feb 12, 2022
… that want to verify that the binding isn't initialized (flutter/flutter#98226)
clocksmith pushed a commit to clocksmith/flutter that referenced this pull request Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants