Skip to content

CupertinoSegmentedControl/CupertinoSlidingSegmentedControl: Add clickable cursor for web - #99551

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
NevercodeHQ:cupertino_segment_control_web_cursor
Mar 28, 2022
Merged

CupertinoSegmentedControl/CupertinoSlidingSegmentedControl: Add clickable cursor for web#99551
fluttergithubbot merged 1 commit into
flutter:masterfrom
NevercodeHQ:cupertino_segment_control_web_cursor

Conversation

@TahaTesser

@TahaTesser TahaTesser commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

part of #86174

Complete details #86174 (comment)

Integration test for web results:

CupertinoSegmentedControl

Launching integration_test/cupertino/cupertino_segement_control.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_segement_control.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:58595/lCFVeemg1dM=/ws
Debug service listening on ws://127.0.0.1:58595/lCFVeemg1dM=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:58595/lCFVeemg1dM=/ws
00:00 +0: Hovering over Cupertino segmented control updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

CupertinoSlidingSegmentedControl

Launching integration_test/cupertino/cupertino_segement_control.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_segement_control.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:59205/yBqwxPo4z7M=/ws
Debug service listening on ws://127.0.0.1:59205/yBqwxPo4z7M=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:59205/yBqwxPo4z7M=/ws
00:00 +0: Hovering over Cupertino sliding segmented control updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 4, 2022
@TahaTesser TahaTesser mentioned this pull request Mar 4, 2022
Closed
Renzo-Olivares
Renzo-Olivares approved these changes Mar 25, 2022
View reviewed changes

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
TahaTesser force-pushed the cupertino_segment_control_web_cursor branch from d716a8e to 78cd3e8 Compare March 28, 2022 07:04
@fluttergithubbot
fluttergithubbot merged commit e4bd5d5 into flutter:master Mar 28, 2022
@TahaTesser
TahaTesser deleted the cupertino_segment_control_web_cursor branch March 28, 2022 08:49
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 28, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 28, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
15b7ee4 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
f8728a6 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
253ac92 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
f9705cd 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
91b92ca 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
eb67a55 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
e6867fe 
…`: Add clickable cursor for web (flutter/flutter#99551)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 29, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 29, 2022
@engine-flutter-autoroll
e4bd5d5 CupertinoSegmentedControl/`CupertinoSlidingSegmentedControl…
45f17ff 
…`: Add clickable cursor for web (flutter/flutter#99551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TahaTesser @Renzo-Olivares @fluttergithubbot