Skip to content

CupertinoSwitch: Add clickable cursor for web - #99554

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
NevercodeHQ:cupertino_switch_web_cursor
Mar 21, 2022
Merged

CupertinoSwitch: Add clickable cursor for web#99554
fluttergithubbot merged 1 commit into
flutter:masterfrom
NevercodeHQ:cupertino_switch_web_cursor

Conversation

@TahaTesser

@TahaTesser TahaTesser commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

part of #86174

Complete details #86174 (comment)

Integration test for web results:

CupertinoSwitch

Launching integration_test/cupertino/cupertino_switch.dart on Chrome in debug mode...
integration_test/cupertino/cupertino_switch.dart:1
DartUri: Unresolved uri: dart:web_sql
DartUri: Unresolved uri: dart:ui

This app is linked to the debug service: ws://127.0.0.1:61184/4_U3tQY6ovE=/ws
Debug service listening on ws://127.0.0.1:61184/4_U3tQY6ovE=/ws
💪 Running with sound null safety 💪
Connecting to VM Service at ws://127.0.0.1:61184/4_U3tQY6ovE=/ws
00:00 +0: Hovering over Cupertino switch updates cursor to clickable on Web
00:00 +1: (tearDownAll)
00:00 +2: All tests passed!

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@flutter-dashboard flutter-dashboard Bot added p: cupertino_ui cupertino_ui package in flutter/packages framework flutter/packages/flutter repository. See also f: labels. labels Mar 4, 2022
@TahaTesser TahaTesser mentioned this pull request Mar 4, 2022
Closed
Renzo-Olivares
Renzo-Olivares approved these changes Mar 18, 2022
View reviewed changes

@Renzo-Olivares Renzo-Olivares left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TahaTesser
TahaTesser force-pushed the cupertino_switch_web_cursor branch from 5104285 to 1cdfa8c Compare March 21, 2022 12:14
@skia-gold

skia-gold commented Mar 21, 2022

Copy link
Copy Markdown

Gold has detected about 1 new digest(s) on patchset 1.
View them at https://flutter-gold.skia.org/cl/github/99554

@flutter-dashboard

flutter-dashboard Bot commented Mar 21, 2022

Copy link
Copy Markdown

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #99554 at sha 1cdfa8c

@flutter-dashboard flutter-dashboard Bot added the will affect goldens Changes to golden files label Mar 21, 2022
@fluttergithubbot
fluttergithubbot merged commit 4cea5ee into flutter:master Mar 21, 2022
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2022
@engine-flutter-autoroll
4cea5ee CupertinoSwitch: Add clickable cursor for web (flutter/flut…
fd2c676 
…ter#99554)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2022
@engine-flutter-autoroll
4cea5ee CupertinoSwitch: Add clickable cursor for web (flutter/flut…
42e3922 
…ter#99554)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Mar 21, 2022
@engine-flutter-autoroll
4cea5ee CupertinoSwitch: Add clickable cursor for web (flutter/flut…
dc2fa39 
…ter#99554)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 21, 2022
@engine-flutter-autoroll
4cea5ee CupertinoSwitch: Add clickable cursor for web (flutter/flut…
5cb5703 
…ter#99554)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 21, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this pull request Mar 21, 2022
@engine-flutter-autoroll
4cea5ee CupertinoSwitch: Add clickable cursor for web (flutter/flut…
1a7f26a 
…ter#99554)
@TahaTesser
TahaTesser deleted the cupertino_switch_web_cursor branch March 22, 2022 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renzo-Olivares Renzo-Olivares Renzo-Olivares approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels. p: cupertino_ui cupertino_ui package in flutter/packages will affect goldens Changes to golden files

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TahaTesser @skia-gold @Renzo-Olivares @fluttergithubbot