Skip to content

Add an inline run menu option to run or watch Bazel Flutter tests - #3507

Merged
DaveShuckerow merged 10 commits into
flutter:masterfrom
DaveShuckerow:test-watch
May 24, 2019
Merged

DaveShuckerow merged 10 commits into
flutter:masterfrom
DaveShuckerow:test-watch

Conversation

@DaveShuckerow

Copy link
Copy Markdown
Contributor

Image: image

@devoncarew

Copy link
Copy Markdown
Contributor

In BazelTestConfigProducer, should we change the name we set to Run + config.getName()? That would parallel the Watch counter_test.dart menu item in the picture above. I'm not 100% sure of this, as we might also need to make the returned name dependent on the execution mode (run vs debug). Thoughts? I suppose we could just use Run ... for both run and debug.

@DaveShuckerow

Copy link
Copy Markdown
Contributor Author

In BazelTestConfigProducer, should we change the name we set to Run + config.getName()? That would parallel the Watch counter_test.dart menu item in the picture above. I'm not 100% sure of this, as we might also need to make the returned name dependent on the execution mode (run vs debug). Thoughts? I suppose we could just use Run ... for both run and debug.

That sounds good to me. I also took the opportunity to make the names easier to read when the test name or file name is long and the configuration name gets truncated.

@DaveShuckerow
DaveShuckerow merged commit 8e5aa06 into flutter:master May 24, 2019
@DaveShuckerow
DaveShuckerow deleted the test-watch branch May 24, 2019 19:30
stevemessick pushed a commit that referenced this pull request May 29, 2019
)

* Set up a second factory for the test configuration

* Everything works

* Fix typo

* Code cleanup and documentation

* Explain producer logic and caveats

* Remove unneeded whitespace

* Rename bazel test run configurations to explicitly say run instead of watch

* Make the name a little easier to read if it gets truncated
alexander-doroshko pushed a commit to alexander-doroshko/flutter-intellij that referenced this pull request Jan 24, 2020
…utter#3507)

* Set up a second factory for the test configuration

* Everything works

* Fix typo

* Code cleanup and documentation

* Explain producer logic and caveats

* Remove unneeded whitespace

* Rename bazel test run configurations to explicitly say run instead of watch

* Make the name a little easier to read if it gets truncated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants