Repository navigation
[camera_android_camerax] Removes internal native library Dart proxy - #10536
Merged
Merged
Conversation
bparrishMines
changed the title
bparrishMines
marked this pull request as ready for review
December 2, 2025 18:43
camsim99
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 9, 2025
github-merge-queue Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 9, 2025
flutter/packages@33a9a81...338ecd3 2025-12-09 [email protected] [shared_preferences_tool] Update dependencies and fix deprecation (flutter/packages#10560) 2025-12-08 [email protected] [ci] Use manual trigger for go_router_batch workflow for testing purp… (flutter/packages#10475) 2025-12-08 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in /packages/camera/camera_android_camerax/android (flutter/packages#10582) 2025-12-08 [email protected] Roll Flutter from 5b87203 to b2de367 (38 revisions) (flutter/packages#10587) 2025-12-08 [email protected] [camera_android_camerax] Removes internal native library Dart proxy (flutter/packages#10536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
reidbaker
pushed a commit
to AbdeMohlbi/flutter
that referenced
this pull request
Dec 10, 2025
…r#179625) flutter/packages@33a9a81...338ecd3 2025-12-09 [email protected] [shared_preferences_tool] Update dependencies and fix deprecation (flutter/packages#10560) 2025-12-08 [email protected] [ci] Use manual trigger for go_router_batch workflow for testing purp… (flutter/packages#10475) 2025-12-08 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in /packages/camera/camera_android_camerax/android (flutter/packages#10582) 2025-12-08 [email protected] Roll Flutter from 5b87203 to b2de367 (38 revisions) (flutter/packages#10587) 2025-12-08 [email protected] [camera_android_camerax] Removes internal native library Dart proxy (flutter/packages#10536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
ivan-vanyusho
pushed a commit
to ivan-vanyusho/packages
that referenced
this pull request
Jan 26, 2026
…lutter#10536) ProxyApis now * Generate a Dart `PigeonOverrides` class that can override constructors and static methods. * Use a test `PigeonInstanceManager` that doesn't make any message calls. This removes the manually written proxy and replaces its use in tests with `PigeonOverrides`. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
…lutter#10536) ProxyApis now * Generate a Dart `PigeonOverrides` class that can override constructors and static methods. * Use a test `PigeonInstanceManager` that doesn't make any message calls. This removes the manually written proxy and replaces its use in tests with `PigeonOverrides`. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
Nakiha
pushed a commit
to Nakiha/VoidPlayer-Flutter
that referenced
this pull request
Sep 28, 2026
flutter/packages@33a9a81...338ecd3 2025-12-09 [email protected] [shared_preferences_tool] Update dependencies and fix deprecation (flutter/packages#10560) 2025-12-08 [email protected] [ci] Use manual trigger for go_router_batch workflow for testing purp… (flutter/packages#10475) 2025-12-08 49699333+dependabot[bot]@users.noreply.github.com [dependabot]: Bump camerax_version from 1.5.1 to 1.5.2 in /packages/camera/camera_android_camerax/android (flutter/packages#10582) 2025-12-08 [email protected] Roll Flutter from 8c91bf9 to 001954a (38 revisions) (flutter/packages#10587) 2025-12-08 [email protected] [camera_android_camerax] Removes internal native library Dart proxy (flutter/packages#10536) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProxyApis now
PigeonOverridesclass that can override constructors and static methods.PigeonInstanceManagerthat doesn't make any message calls.This removes the manually written proxy and replaces its use in tests with
PigeonOverrides.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3