[pigeon] Optimize data class equality and hashing in Dart, Kotlin, java, and Swift, adds equality in other languages by tarrinneal · Pull Request #11140 · flutter/packages

tarrinneal · 2026-02-28T00:41:20Z

This PR optimizes the generated equality (==) and hashing (hashCode/hash) logic for data classes across All languages. These have been bothering me for a while, and I wanted to break out a new pr before the NI code is in review.

gemini-code-assist

Code Review

This pull request introduces significant performance optimizations for data class equality and hashing in Dart, Kotlin, and Swift by avoiding the creation of intermediate lists. The changes are well-implemented and include necessary updates to helper utilities like deepEquals and deepHash for robust recursive comparisons. The addition of generator tests for each language is a great way to ensure the new logic is correct. I have a couple of minor suggestions to improve the generator code's maintainability.

tarrinneal · 2026-03-04T06:06:18Z

/gemini review

tarrinneal · 2026-03-06T05:40:16Z

@stuartmorgan-g your comments are addressed, I'm still planning on reading up a bit on things before landing.

stuartmorgan-g

Minor notes (mostly orthodontia), but otherwise LGTM.

stuartmorgan-g · 2026-03-09T17:00:19Z

+      return pigeonDeepEquals(name, that.name)
+          && pigeonDeepEquals(description, that.description)
+          && pigeonDeepEquals(code, that.code)
+          && pigeonDeepEquals(data, that.data);


This doesn't actually, any non-collections well return first before any type checking.

I'm not following. The first line in this statement is calling pigeonDeepEquals with two strings. We know at compile time they are strings. But we are calling pigeonDeepEquals for them which will do runtime checks for whether they are:

byte arrays

int arrays

long arrays

double arrays

Lists

Maps

Doubles

Floats

and only then, after all of that, check that the strings are equal.

tarrinneal · 2026-03-11T00:08:11Z

(mostly orthodontia)

Can we add a gobject lint tool?

tarrinneal · 2026-03-11T21:04:56Z

@stuartmorgan-g done done

tarrinneal · 2026-03-12T00:44:45Z

@stuartmorgan-g While I technically need your review. Gemini said: "You have essentially achieved the holy grail of cross-platform plugin design. You maintained strict, identical behavioral output while perfectly adapting to the efficiency constraints and memory safety rules of each specific compiler."

So I think I'm set.

stuartmorgan-g

LGTM

…Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140)

flutter/packages@8dcfd11...5909bdd 2026-03-25 [email protected] [ci] add more permissions for create-pull-request (flutter/packages#11302) 2026-03-25 [email protected] [various] Add `unintended_html_in_doc_comment` to analysis options (flutter/packages#11303) 2026-03-25 [email protected] Use deprecated dependency until legacy renderer is removed (flutter/packages#11185) 2026-03-25 [email protected] [in_app_purchase_storekit] Address flaky tests (flutter/packages#11270) 2026-03-25 [email protected] [google_maps_flutter] Fix A2A iOS builds (flutter/packages#11290) 2026-03-25 [email protected] [mustache_template] Fix broken README link (flutter/packages#11306) 2026-03-25 [email protected] [ci] Add a workflow to auto-remove CICD label (flutter/packages#11301) 2026-03-25 [email protected] [various] Convert plugin builds to Kotlin gradle (flutter/packages#11172) 2026-03-25 [email protected] [webview_flutter_platform_interface] Add support for getting cookie (flutter/packages#11037) 2026-03-25 [email protected] [cupertino_icons] Remove empty Dart file (flutter/packages#11308) 2026-03-25 [email protected] [camera] Regenerate iOS example with Swift (flutter/packages#11283) 2026-03-25 [email protected] [pigeon] Optimize data class equality and hashing in Dart, Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140) 2026-03-25 [email protected] [two_dimensional_scrollables] Fix span border decorations in flipped cross axes (flutter/packages#11334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…va, and Swift, adds equality in other languages (flutter#11140) This PR optimizes the generated equality (==) and hashing (hashCode/hash) logic for data classes across All languages. These have been bothering me for a while, and I wanted to break out a new pr before the NI code is in review.

…er#184123) flutter/packages@8dcfd11...5909bdd 2026-03-25 [email protected] [ci] add more permissions for create-pull-request (flutter/packages#11302) 2026-03-25 [email protected] [various] Add `unintended_html_in_doc_comment` to analysis options (flutter/packages#11303) 2026-03-25 [email protected] Use deprecated dependency until legacy renderer is removed (flutter/packages#11185) 2026-03-25 [email protected] [in_app_purchase_storekit] Address flaky tests (flutter/packages#11270) 2026-03-25 [email protected] [google_maps_flutter] Fix A2A iOS builds (flutter/packages#11290) 2026-03-25 [email protected] [mustache_template] Fix broken README link (flutter/packages#11306) 2026-03-25 [email protected] [ci] Add a workflow to auto-remove CICD label (flutter/packages#11301) 2026-03-25 [email protected] [various] Convert plugin builds to Kotlin gradle (flutter/packages#11172) 2026-03-25 [email protected] [webview_flutter_platform_interface] Add support for getting cookie (flutter/packages#11037) 2026-03-25 [email protected] [cupertino_icons] Remove empty Dart file (flutter/packages#11308) 2026-03-25 [email protected] [camera] Regenerate iOS example with Swift (flutter/packages#11283) 2026-03-25 [email protected] [pigeon] Optimize data class equality and hashing in Dart, Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140) 2026-03-25 [email protected] [two_dimensional_scrollables] Fix span border decorations in flipped cross axes (flutter/packages#11334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…va, and Swift, adds equality in other languages (flutter#11140) This PR optimizes the generated equality (==) and hashing (hashCode/hash) logic for data classes across All languages. These have been bothering me for a while, and I wanted to break out a new pr before the NI code is in review.

flutter/packages@8dcfd11...5909bdd 2026-03-25 [email protected] [ci] add more permissions for create-pull-request (flutter/packages#11302) 2026-03-25 [email protected] [various] Add `unintended_html_in_doc_comment` to analysis options (flutter/packages#11303) 2026-03-25 [email protected] Use deprecated dependency until legacy renderer is removed (flutter/packages#11185) 2026-03-25 [email protected] [in_app_purchase_storekit] Address flaky tests (flutter/packages#11270) 2026-03-25 [email protected] [google_maps_flutter] Fix A2A iOS builds (flutter/packages#11290) 2026-03-25 [email protected] [mustache_template] Fix broken README link (flutter/packages#11306) 2026-03-25 [email protected] [ci] Add a workflow to auto-remove CICD label (flutter/packages#11301) 2026-03-25 [email protected] [various] Convert plugin builds to Kotlin gradle (flutter/packages#11172) 2026-03-25 [email protected] [webview_flutter_platform_interface] Add support for getting cookie (flutter/packages#11037) 2026-03-25 [email protected] [cupertino_icons] Remove empty Dart file (flutter/packages#11308) 2026-03-25 [email protected] [camera] Regenerate iOS example with Swift (flutter/packages#11283) 2026-03-25 [email protected] [pigeon] Optimize data class equality and hashing in Dart, Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140) 2026-03-25 [email protected] [two_dimensional_scrollables] Fix span border decorations in flipped cross axes (flutter/packages#11334) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Improve efficiency in some methods

82065a8

tarrinneal requested a review from stuartmorgan-g February 28, 2026 00:41

github-actions Bot added p: pigeon platform-android platform-ios platform-macos labels Feb 28, 2026

gemini-code-assist Bot reviewed Feb 28, 2026

View reviewed changes

tarrinneal added 7 commits February 27, 2026 18:22

analyze this

9861c00

format

11daedd

less repeating, and less listing

e197fc0

allow individual class types to not have colliding hashes

cbf4096

improve deep equals for non-collections

935aa47

allowing for NaN or other cases where identical is better

4e9541f

more tests, add other languages, unify behavior across platforms

f30b44c

github-actions Bot added the platform-windows label Mar 3, 2026

first pass at gobject

08a79f3

github-actions Bot added the platform-linux label Mar 3, 2026

tarrinneal added 7 commits March 3, 2026 12:09

Merge branch 'main' of https://github.com/flutter/packages into effic

8cb51ac

analyze

ddc41c2

delete random extra files

4ad3636

fix kotlin generator change that broke unit test

0a08ef5

fix broken gobject and cpp code

5855b23

more bugs on languages I can't compile locally

f99e64a

last few issues I hope

101fb0f

tarrinneal changed the title ~~[pigeon] Optimize data class equality and hashing in Dart, Kotlin, and Swift~~ [pigeon] Optimize data class equality and hashing in Dart, Kotlin, and Swift, adds equality in other languages Mar 4, 2026

tarrinneal added 4 commits March 3, 2026 20:47

not being able to run things locally sucks

7309d17

bigobj

24d0f23

consolidate tests

21ad393

revert project files

94a58c8

nits and nats

38cffb2

stuartmorgan-g reviewed Mar 9, 2026

View reviewed changes

tarrinneal added 3 commits March 10, 2026 17:19

dentist has been busy today

a2a80b5

Merge branch 'main' of https://github.com/flutter/packages into effic

b5b4506

fix std::map hash

1305a1d

tarrinneal requested a review from stuartmorgan-g March 11, 2026 00:27

tarrinneal added 4 commits March 11, 2026 10:24

even more better

a5ce9cc

Merge branch 'main' of https://github.com/flutter/packages into effic

6d92541

revert dumb change

eba918b

namespace

5097bdc

Triple checked methods

0a5adee

tarrinneal added the CICD Run CI/CD label Mar 12, 2026

stuartmorgan-g approved these changes Mar 19, 2026

View reviewed changes

Comment thread packages/pigeon/example/app/macos/Runner/messages.g.m Outdated

tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Mar 20, 2026

nix id

2aeb4a7

tarrinneal added CICD Run CI/CD and removed CICD Run CI/CD labels Mar 25, 2026

auto-submit Bot merged commit 3e15247 into flutter:main Mar 25, 2026
81 checks passed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 25, 2026

3e15247b2 [pigeon] Optimize data class equality and hashing in Dart, …

9522ddd

…Kotlin, java, and Swift, adds equality in other languages (flutter/packages#11140)

engine-flutter-autoroll mentioned this pull request Mar 25, 2026

Roll Packages from 8dcfd1186ef9 to 5909bdde6090 (13 revisions) flutter/flutter#184123

Merged

Conversation

tarrinneal commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

tarrinneal commented Mar 4, 2026

Uh oh!

tarrinneal commented Mar 6, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g Mar 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tarrinneal commented Mar 11, 2026

Uh oh!

tarrinneal commented Mar 11, 2026

Uh oh!

tarrinneal commented Mar 12, 2026

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tarrinneal commented Feb 28, 2026 •

edited

Loading