[image_picker] Fix android-16 not picking up file by ashutosh2014 · Pull Request #11320 · flutter/packages

ashutosh2014 · 2026-03-21T21:28:11Z

Description

Fixes an issue where image_picker returns a null file after selecting an image from the gallery on Android 16+, caused by incorrect handling of content URIs in the Android implementation.

Changes

Updated ImagePickerUtils.java to handle Android 16+ behavior correctly
Fixed file picking logic

Tests

Added unit tests for effectiveUsePhotoPicker to verify behavior on Android 16 (API 36)
Ensured correct behavior across API levels

Issue

Fixes flutter/flutter#182071
Fixes flutter/flutter#184826

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

gemini-code-assist

Code Review

This pull request addresses an issue on Android 16 (API 36) where the image picker would not return a file path. The solution is to enforce the use of the Android Photo Picker on API 36 and higher, which is implemented via a new utility method, effectiveUsePhotoPicker. This logic is consistently applied throughout the ImagePickerDelegate. The change is also accompanied by new unit tests, which is great. My review includes a minor suggestion to simplify the logic in the new utility method for improved conciseness.

stuartmorgan-g · 2026-03-22T16:39:34Z

I linked to at least one issue that this PR fixes in the description above.

Thanks for the contribution! You’ve checked boxes in the PR checklist above that are not reflected in this PR, so I’m assuming this is a work in progress and am marking it as a Draft. Please review the checklist, updating the PR as appropriate, and when the state of the PR as posted reflects the checklist please feel free to mark it as ready for review.

ashutosh2014 · 2026-03-22T16:46:55Z

@stuartmorgan-g

flutter/flutter#182071

This is the issue fixed by this current PR

gemini-code-assist

Code Review

This pull request addresses an issue with file selection on Android API 36+ by enforcing the use of the Android Photo Picker. The implementation introduces a new utility method and is accompanied by corresponding tests, which is great. My feedback focuses on improving the clarity of a new constant and associated comments to prevent potential confusion regarding Android versions and API levels.

gemini-code-assist · 2026-03-22T16:49:16Z

+* Fixes gallery image/video selection on Android 16 (API 36) returning no paths when
+  `useAndroidPhotoPicker` was false. The plugin now uses the Android Photo Picker on API 36 and
+  above regardless of that flag, avoiding a broken `ACTION_GET_CONTENT` result from the system UI.


The reference to "Android 16 (API 36)" could be confusing, as Android version 16 doesn't correspond to API level 36. To improve clarity, consider referring to the API level directly.

Suggested change

* Fixes gallery image/video selection on Android 16 (API 36) returning no paths when

`useAndroidPhotoPicker` was false. The plugin now uses the Android Photo Picker on API 36 and

above regardless of that flag, avoiding a broken `ACTION_GET_CONTENT` result from the system UI.

* Fixes gallery image/video selection on Android API 36+ returning no paths when

`useAndroidPhotoPicker` was false. The plugin now uses the Android Photo Picker on API 36 and

above regardless of that flag, avoiding a broken `ACTION_GET_CONTENT` result from the system UI.

gemini-code-assist · 2026-03-22T16:49:16Z

 import java.util.Arrays;

 final class ImagePickerUtils {
+  private static final int ANDROID_16_API_LEVEL = 36;


The constant name ANDROID_16_API_LEVEL is potentially misleading, as Android version 16 corresponds to API level 23 (Jelly Bean), not 36. A more generic name like API_LEVEL_36 would be clearer and avoid confusion. Please also update its usage within this file.

Suggested change

private static final int ANDROID_16_API_LEVEL = 36;

private static final int API_LEVEL_36 = 36;

gemini-code-assist · 2026-03-22T16:49:16Z

+   * androidx.activity.result.contract.ActivityResultContracts.PickVisualMedia} (Android Photo
+   * Picker) instead of {@link android.content.Intent#ACTION_GET_CONTENT}.
+   *
+   * <p>On Android 16 (API 36), {@code ACTION_GET_CONTENT} for images may be handled by the system


The reference to "Android 16 (API 36)" is potentially confusing. To improve clarity, it would be better to refer to the API level directly.

Suggested change

* <p>On Android 16 (API 36), {@code ACTION_GET_CONTENT} for images may be handled by the system

* <p>On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system

stuartmorgan-g · 2026-03-22T16:58:26Z

@ashutosh2014 Please edit the PR description to include that information, along with the other requested information, instead of leaving placeholder text there and putting the requested information only in the comments.

ashutosh2014 · 2026-03-22T17:54:53Z

@stuartmorgan-g Updated PR description with full details, tests, and issue link. Ready for review.

gemini-code-assist

Code Review

This pull request addresses an issue with file picking on Android API 36+ by conditionally forcing the use of the Android Photo Picker. A new method, effectiveUsePhotoPicker, is introduced in ImagePickerUtils.java to encapsulate this logic, which is now used throughout ImagePickerDelegate.java. The change also includes unit tests for the new logic and updates the package's changelog and version.

…droid-16-not-picking-up-file

gmackall

LGTM but it would be good to also update the docs for useAndroidPhotoPicker

packages/packages/image_picker/image_picker_android/lib/image_picker_android.dart

Line 23 in e627503

bool useAndroidPhotoPicker = false;

to indicate it is not respected on android 16+

cc @tarrinneal for secondary review

…droid-16-not-picking-up-file

…ps://github.com/ashutosh2014/packages into image-picker-Fix-android-16-not-picking-up-file

ashutosh2014 · 2026-08-25T16:31:56Z

@stuartmorgan-g Thanks for comments, Can you check now?

stuartmorgan-g · 2026-08-25T16:43:24Z

@@ -1,3 +1,7 @@
+## NEXT


Which of the documented versioning exemptions (per the link in the checklist) do you believe this PR falls under?

Versioning Fixed.

stuartmorgan-g · 2026-08-27T15:01:57Z

@ashutosh2014 Every time you push a new commit to this PR, it requires human intervention to re-add the CICD label, and then all the tests have to run again, making it take longer to land. Please don't just push merges for no reason.

tarrinneal · 2026-08-28T03:26:34Z

These files are not formatted correctly (see diff below):
packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java

To fix run the repository tooling format command: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code
or copy-paste this command into your terminal:
patch -p1 <<DONE
diff --git a/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java b/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java
index 438f1860da..ce61b61fad 100644
--- a/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java
+++ b/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java
@@ -94,8 +94,8 @@ final class ImagePickerUtils {
* androidx.activity.result.contract.ActivityResultContracts.PickVisualMedia} (Android Photo
* Picker) instead of {@link android.content.Intent#ACTION_GET_CONTENT}.
*

- On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system
- photo picker's {@code PhotopickerGetContentActivity}. That path combined with {@code

- On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system photo
- picker's {@code PhotopickerGetContentActivity}. That path combined with {@code
- startActivityForResult} can return {@link android.app.Activity#RESULT_OK} without {@link
- android.content.Intent#getData()} or usable {@link android.content.ClipData}, so the plugin
- would complete with no paths. The {@code PickVisualMedia} contract uses the Activity Result API

…ps://github.com/ashutosh2014/packages into pr/11320

ashutosh2014 · 2026-08-28T04:47:38Z

These files are not formatted correctly (see diff below): packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java

To fix run the repository tooling format command: https://github.com/flutter/packages/blob/main/script/tool/README.md#format-code or copy-paste this command into your terminal: patch -p1 <<DONE diff --git a/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java b/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java index 438f1860da..ce61b61fad 100644 --- a/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java +++ b/packages/image_picker/image_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java @@ -94,8 +94,8 @@ final class ImagePickerUtils { * androidx.activity.result.contract.ActivityResultContracts.PickVisualMedia} (Android Photo * Picker) instead of {@link android.content.Intent#ACTION_GET_CONTENT}. *

On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system

photo picker's {@code PhotopickerGetContentActivity}. That path combined with {@code

On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system photo

picker's {@code PhotopickerGetContentActivity}. That path combined with {@code

startActivityForResult} can return {@link android.app.Activity#RESULT_OK} without {@link

android.content.Intent#getData()} or usable {@link android.content.ClipData}, so the plugin

would complete with no paths. The {@code PickVisualMedia} contract uses the Activity Result API

Done

flutter/packages@18fe786...f9b3954 2026-09-03 [email protected] [image_picker] Fix android-16 not picking up file (flutter/packages#11320) 2026-09-02 [email protected] [material_ui] Migrate off of flutter_test's find.byTooltip and on to the local findByTooltip (flutter/packages#12492) 2026-09-02 [email protected] [material_ui] Remove no shuffle from text field tests (flutter/packages#12547) 2026-09-02 [email protected] Add Material style variant enum (#12221) (flutter/packages#12717) 2026-09-02 [email protected] [go_router_builder] Report duplicate route paths at build time (flutter/packages#12399) 2026-09-02 [email protected] [google_sign_in] PR 1/4 google_sign_in_ios SPM packaging (flutter/packages#12654) 2026-09-02 [email protected] [video_player_android] Report display size for anamorphic video (flutter/packages#12360) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

## Description Fixes an issue where `image_picker` returns a null file after selecting an image from the gallery on Android 16+, caused by incorrect handling of content URIs in the Android implementation. ## Changes - Updated `ImagePickerUtils.java` to handle Android 16+ behavior correctly - Fixed file picking logic ## Tests - Added unit tests for `effectiveUsePhotoPicker` to verify behavior on Android 16 (API 36) - Ensured correct behavior across API levels ## Issue Fixes flutter/flutter#182071 Fixes flutter/flutter#184826 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

...

a0f3b70

ashutosh2014 requested a review from gmackall as a code owner March 21, 2026 21:28

github-actions Bot added p: image_picker platform-android labels Mar 21, 2026

gemini-code-assist Bot reviewed Mar 21, 2026

View reviewed changes

Comment thread ...ge_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java

Update ImagePickerUtils.java

362cf17

stuartmorgan-g marked this pull request as draft March 22, 2026 16:39

ashutosh2014 marked this pull request as ready for review March 22, 2026 16:46

gemini-code-assist Bot reviewed Mar 22, 2026

View reviewed changes

stuartmorgan-g marked this pull request as draft March 22, 2026 16:58

........

afecdf1

ashutosh2014 marked this pull request as ready for review March 22, 2026 17:54

gemini-code-assist Bot reviewed Mar 22, 2026

View reviewed changes

Comment thread ...ge_picker_android/android/src/main/java/io/flutter/plugins/imagepicker/ImagePickerUtils.java

ashutosh2014 added 3 commits March 26, 2026 13:59

Merge remote-tracking branch 'upstream/main' into image-picker-Fix-an…

f70492c

…droid-16-not-picking-up-file

Update pubspec.yaml

385d2e3

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

da290e7

gmackall added the CICD Run CI/CD label Mar 26, 2026

gmackall approved these changes Mar 26, 2026

View reviewed changes

ashutosh2014 added 3 commits March 27, 2026 12:00

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

b1a240d

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

ce77b61

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

748ba3b

stuartmorgan-g requested a review from tarrinneal March 31, 2026 18:25

ashutosh2014 added 4 commits April 1, 2026 23:03

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

681bd67

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

7194411

Merge remote-tracking branch 'upstream/main' into image-picker-Fix-an…

76ed499

…droid-16-not-picking-up-file

Merge branch 'image-picker-Fix-android-16-not-picking-up-file' of htt…

256b9f8

…ps://github.com/ashutosh2014/packages into image-picker-Fix-android-16-not-picking-up-file

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

ec59c35

ashutosh2014 requested a review from stuartmorgan-g August 25, 2026 16:31

stuartmorgan-g reviewed Aug 25, 2026

View reviewed changes

Versioning Fixed

adfe365

ashutosh2014 requested a review from stuartmorgan-g August 25, 2026 21:37

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

df88339

stuartmorgan-g approved these changes Aug 27, 2026

View reviewed changes

stuartmorgan-g added the CICD Run CI/CD label Aug 27, 2026

Merge branch 'main' into image-picker-Fix-android-16-not-picking-up-file

7847b79

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 27, 2026

stuartmorgan-g added the CICD Run CI/CD label Aug 27, 2026

ashutosh2014 added 2 commits August 28, 2026 10:16

Reformatted

98653f1

Merge branch 'image-picker-Fix-android-16-not-picking-up-file' of htt…

be94653

…ps://github.com/ashutosh2014/packages into pr/11320

flutter-dashboard Bot removed the CICD Run CI/CD label Aug 28, 2026

ashutosh2014 requested a review from tarrinneal August 28, 2026 04:47

Merge branch 'main' into pr/11320

c3be180

stuartmorgan-g added the CICD Run CI/CD label Aug 28, 2026

Re-bump version after incorrect merge

5da7d3b

flutter-dashboard Bot removed the CICD Run CI/CD label Sep 1, 2026

stuartmorgan-g added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App labels Sep 1, 2026

auto-submit Bot merged commit f9b3954 into flutter:main Sep 3, 2026
14 checks passed

engine-flutter-autoroll mentioned this pull request Sep 3, 2026

Roll Packages from 18fe786e24b3 to f9b3954a113d (7 revisions) flutter/flutter#192235

Merged

	private static final int ANDROID_16_API_LEVEL = 36;
	private static final int API_LEVEL_36 = 36;

	* <p>On Android 16 (API 36), {@code ACTION_GET_CONTENT} for images may be handled by the system
	* <p>On Android API 36+, {@code ACTION_GET_CONTENT} for images may be handled by the system

Conversation

ashutosh2014 commented Mar 21, 2026 • edited by stuartmorgan-g Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Tests

Issue

Pre-Review Checklist

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

stuartmorgan-g commented Mar 22, 2026

Uh oh!

ashutosh2014 commented Mar 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot Mar 22, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Mar 22, 2026

Uh oh!

ashutosh2014 commented Mar 22, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

gmackall left a comment

Choose a reason for hiding this comment

Uh oh!

ashutosh2014 commented Aug 25, 2026

Uh oh!

stuartmorgan-g Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

ashutosh2014 Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g commented Aug 27, 2026

Uh oh!

tarrinneal commented Aug 28, 2026

Uh oh!

ashutosh2014 commented Aug 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ashutosh2014 commented Mar 21, 2026 •

edited by stuartmorgan-g

Loading