Skip to content

[material_ui, cupertino_ui] Migrate macros that contain @tool - #12271

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
dkwingsmt:migrate-macros
Jul 28, 2026
Merged

auto-submit[bot] merged 6 commits into
flutter:mainfrom
dkwingsmt:migrate-macros

Conversation

@dkwingsmt

@dkwingsmt dkwingsmt commented Jul 22, 2026 •

Copy link
Copy Markdown
Contributor

See flutter/flutter#189629.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Jul 22, 2026
@github-actions github-actions Bot added triage-framework Should be looked at in framework triage p: cupertino_ui p: material_ui labels Jul 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces several {@macro ...} documentation directives with explicit doc comments and temporary TODO notes across multiple UI components in the cupertino_ui and material_ui packages. A review comment identifies a copy-paste error in packages/material_ui/lib/src/autocomplete.dart where the documentation for textEditingController incorrectly references [RawAutocomplete.focusNode] instead of [RawAutocomplete.textEditingController].

Comment thread packages/material_ui/lib/src/autocomplete.dart Outdated
Comment thread packages/cupertino_ui/lib/src/text_field.dart Outdated
Comment thread packages/material_ui/lib/src/text_field.dart Outdated

@Piinks Piinks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@auto-submit

auto-submit Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

autosubmit label was removed for flutter/packages/12271, because - The status or check suite Dashboard Checks has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 23, 2026
@Piinks

Piinks commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Confirmed with @chunhtai this just needs pending change log files to unblock. The batch release process takes the pending changelog files (one per PR to avoid conflicts) and compiles them together for the final changelog before release. See #12274

@Piinks Piinks added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 28, 2026
@auto-submit
auto-submit Bot merged commit 11f9c59 into flutter:main Jul 28, 2026
13 checks passed
navaronbracke pushed a commit to navaronbracke/flutter that referenced this pull request Jul 29, 2026
…er#190216)

flutter/packages@3e63635...dd11626

2026-07-29 [email protected] [pigeon] Clean up legacy registrant
code (flutter/packages#12205)
2026-07-29 [email protected] [go_router] Add
BlockedInitialNavigationException for blocked initial deep links
(flutter/packages#12213)
2026-07-28 [email protected] [file_selector] Switch to Swift
Testing (flutter/packages#12235)
2026-07-28 [email protected] Exempt
evals directories from version checks (flutter/packages#12299)
2026-07-28 [email protected] [material_ui,
cupertino_ui] Migrate macros that contain `@tool`
(flutter/packages#12271)
2026-07-28 [email protected] [material_ui, cupertino_ui] Fix API doc
references (flutter/packages#12274)
2026-07-28 [email protected]
[camera_android_camerax] Delete `GeneratedCameraxLibrary.java`
(flutter/packages#12294)
2026-07-28 [email protected] Roll Flutter from
9988960 to 0f02463 (16 revisions) (flutter/packages#12300)
2026-07-28 [email protected] [vector_graphics_compiler] Ignore
unrecognized font-weight values (flutter/packages#12199)
2026-07-28 [email protected] [tool] Support promoting to 1.0 in
batch releases (flutter/packages#12262)
2026-07-28 [email protected] ci: Fix Zizmor
github-env failure in install_flutter action (flutter/packages#12298)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected] on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Rusino pushed a commit to Rusino/flutter that referenced this pull request Sep 24, 2026
…es, and migrate some `@tool` directives (flutter#189670)

This PR consists of two parts of changes.

## Migrate some `@tool` directives

As part of flutter#189629, this PR
migrates specific templates used by the `material_ui` and `cupertino_ui`
packages from `{@tool}` directives to standard dartdoc to ensure they
render correctly within these packages. This migration is limited to
only these essential `{@tool}` instances, as Dartdoc does not currently
provide native support for Dartpad.

Note that Dartpad notices ("_To see it in action, copy and run this code
snippet on Dartpad_") are expanded, unlike in
flutter/packages#12120 where they're macros.
This is necessary because Dartdoc can't correctly handle nested
templates and macros, preventing inner macros from expanding correctly.

This PR will be followed by reverting
flutter/packages#12271, which constitutes the
final step of flutter#189629. I have
verified that the package docs will render correctly after the revert.

## Make `check_code_samples.dart‎` support the standard example
directives

Since the examples now consist of two styles, the legacy style "See code
in" and the standard style `@example`,
`check_code_samples.dart‎` needs to be updated to recognize the standard
`@example` directives so that it won't incorrectly report that these
examples files are not used by any docs.

## Pre-launch Checklist

- [ ] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [ ] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [ ] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [ ] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [ ] I signed the [CLA].
- [ ] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [ ] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [ ] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

If this change needs to override an active code freeze, provide a
comment explaining why. The code freeze workflow can be overridden by
code reviewers. See pinned issues for any active code freezes with
guidance.

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD p: cupertino_ui p: material_ui triage-framework Should be looked at in framework triage

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants