Repository navigation
Conversation
github-actions
Bot
added
p: material_ui
triage-design
Mairramer
changed the title
| isEmpty: widget._isEmpty, | ||
| isFocused: _hasPrimaryFocus, | ||
| isHovering: _isHovering, | ||
| expands: widget.isExpanded, |
There was a problem hiding this comment.
The change in this PR is not the same as the ported PR. Please make sure they are the same. Also please make sure all items in "Pre-Review Checklist" have been checked. Thank you:)
There was a problem hiding this comment.
I'll definitely look into this. I'm not sure why it didn't pick up all the commits.
There was a problem hiding this comment.
I used a script to automate the process, but git cherry-pick $(git rev-list --no-merges --reverse refs/flutter-master..refs/pr-181040) is failing. The script is meant to reproduce the actual commits from the PR in their original order, without including merge commits, rather than blindly cherry-picking a range of commits.
I also tried doing it manually, but I'm still getting an error. I think it might be better to use the latest valid commit instead. Maybe @Piinks can help with this.
There was a problem hiding this comment.
I'm validating the other PRs as well. It seems to be happening with older PRs, hmm.
There was a problem hiding this comment.
Have you tried to follow the instruction in flutter/flutter#188444? I give it a try and seems we are able to port the commits, see the comparison https://github.com/flutter/packages/compare/main...QuncCccccc:packages:port-181040?expand=1
There was a problem hiding this comment.
Found the problem. Turns out it was between the chair and the keyboard. Thanks for your patience.
I had to create another PR: #12606, since this one wasn't picking up the changes due to an error on my part.
|
An existing Git SHA, To re-trigger presubmits after closing or re-opeing a PR, or pushing a HEAD commit (i.e. with |
3 participants
This PR fixes the visual issue where the underline of a
DropdownButtonFormFielddid not align at the bottom of its expanded container.Fixes flutter/flutter#162350
Port of flutter/flutter#181040.
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2