Repository navigation
Conversation
github-actions
Bot
added
framework
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request addresses a visual bug in DropdownButtonFormField where the underline did not align to the bottom when the widget was expanded vertically. The fix correctly utilizes the expands property of the InputDecorator by passing the isExpanded value to it. This ensures the decorator, and thus its underline, expands to fill the available vertical space. A new widget test has been added to verify this behavior, confirming the fix. The changes are logical and well-implemented. My only suggestion is to update the documentation for the isExpanded property to reflect its new role in vertical expansion, which I've detailed in a specific comment.
|
This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
There was a problem hiding this comment.
Code Review
This pull request correctly fixes an alignment issue with the DropdownButtonFormField's underline when isExpanded is true. The fix involves passing the isExpanded property to the underlying InputDecorator, which correctly makes it expand to fill its container's height. The documentation for isExpanded has also been helpfully updated to reflect this behavior, and a new regression test has been added to verify the fix. The changes are well-implemented and look good.
50c1724 to
76084ba
Compare
3bee679 to
c620da1
Compare
241b952 to
2d867ed
Compare
QuncCccccc
left a comment
QuncCccccc
left a comment
There was a problem hiding this comment.
Sorry for the late response. I'll make sure we made progress this week:)
QuncCccccc
added
autosubmit
auto-submit
Bot
removed
the
autosubmit
|
autosubmit label was removed for flutter/flutter/181040, because This PR has not met approval requirements for merging. The PR author is not a member of flutter-hackers and needs 1 more review(s) in order to merge this PR.
|
|
autosubmit label was removed for flutter/flutter/181040, because - The status or check suite ci.yaml validation has failed. Please fix the issues identified (or deflake) before re-applying this label. |
|
Status: g3fix has been approved, and Google Testing has passed with the g3fix. I'm deflaking the other presubmit checks. Once everything is green, we can mark this PR as complete and archive it for unfreezing. |
|
Seems we need a roller to approve the CL to pass google testing. 
|
|
It's ok. The Google test has passed at least once, indicating that this is probably ok. I'll mark that this PR has reached completion. At the moment we're not able to merge this PR for the moment due to the Material/Cupertino code freeze (#184093). As soon as the decoupling is complete, we will post a way to port this PR to the new packages to land. In the meantime, I'll convert this PR to a draft and apply a label so that we can quickly find it when the freeze is lifted. Thanks for your contribution! |
dkwingsmt
added
the
waiting for code freeze
Piinks
added
the
Decoupling: Not ready to port yet
|
I've marked this PR as not ready to port to flutter/packages yet. |
|
material_ui and cupertino_ui are now accepting contributions. :) This PR can be ported over to flutter/packages! Guidance and instructions for easily porting over can be found in #188444 |
Piinks
added
Decoupling: Port to flutter/packages
|
@QuncCccccc @dkwingsmt Ported to flutter/packages#12551. |
…om (#12606) This PR fixes the visual issue where the underline of a `DropdownButtonFormField` did not align at the bottom of its expanded container. Fixes flutter/flutter#162350 Port of flutter/flutter#181040. ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
5 participants
This PR fixes the visual issue where the underline of a
DropdownButtonFormFielddid not align at the bottom of its expanded container.Fixes #162350
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.