[material_ui] Declare Flutter SDK dependencies in the pubspec.yaml for tool/gen_defaults by jason-simmons · Pull Request #12623 · flutter/packages

jason-simmons · 2026-08-25T18:32:58Z

This is required for running the Dart analyzer within the tool/gen_defaults package.

…r tool/gen_defaults This is required for running the Dart analyzer within the tool/gen_defaults package.

elliette

Thank you!!

gemini-code-assist

Code Review

This pull request adds a Flutter SDK environment constraint and dependency to the pubspec.yaml file in the gen_defaults tool. The review feedback points out that the specified Flutter SDK version constraint (>=3.44.0) is invalid as it has not been released yet, which will cause pub get to fail, and suggests correcting it to a valid version.

gemini-code-assist · 2026-08-25T18:33:57Z


 environment:
  sdk: ^3.12.0
+  flutter: ">=3.44.0"


The Flutter SDK version constraint is set to >=3.44.0. However, Flutter 3.44.0 is not a released version yet (current stable versions are in the 3.2x range). This constraint will cause flutter pub get to fail on all current Flutter SDKs. This is likely a typo for >=3.24.0 or another existing version. Please correct this to a valid version.

flutter: ">=3.24.0"

flutter: ">=3.44.0" matches the constraint in https://github.com/flutter/packages/blob/main/packages/material_ui/pubspec.yaml

(The latest version in Flutter's stable branch is currently 3.47.1)

flutter-dashboard · 2026-08-25T19:03:48Z

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

bparrishMines · 2026-08-25T20:30:16Z

cc @stuartmorgan-g @elliette @jason-simmons

This is causing failures in post submit with the formatter:

diff --git a/packages/material_ui/tool/gen_defaults/analysis_options.yaml b/packages/material_ui/tool/gen_defaults/analysis_options.yaml
index 1fb98de01a..4d7fbb072b 100644
--- a/packages/material_ui/tool/gen_defaults/analysis_options.yaml
+++ b/packages/material_ui/tool/gen_defaults/analysis_options.yaml
@@ -2,3 +2,12 @@ include: ../../../../analysis_options.yaml
 
 formatter:
   page_width: 100
+analyzer:
+  exclude:
+    - build/**
+    - android/**
+    - ios/**
+    - web/**
+    - windows/**
+    - macos/**
+    - linux/**

I think it may be caused by flutter pub get though.

stuartmorgan-g · 2026-08-25T20:32:52Z

Yes, pub get will do that automigration.

How are we not seeing these things in presubmit?

stuartmorgan-g · 2026-08-25T20:34:30Z

Yes, pub get will do that automigration.

And to be clear, the fix is just to check that change in.

bparrishMines · 2026-08-25T20:36:49Z

I can make the PR.

…pub get` on pacakage (#12626) Fix tool package in `material_ui`. Post submit fix for #12623 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…r tool/gen_defaults (flutter#12623) This is required for running the Dart analyzer within the tool/gen_defaults package.

…pub get` on pacakage (flutter#12626) Fix tool package in `material_ui`. Post submit fix for flutter#12623 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

…r#191886) flutter/packages@740f093...bd3cbc1 2026-08-26 [email protected] Roll Flutter from 9a82789 to 15d8908 (37 revisions) (flutter/packages#12619) 2026-08-26 [email protected] [google_maps_flutter] Convert simple object controllers to Swift (flutter/packages#12618) 2026-08-26 [email protected] [material_ui] `gen_defaults` should follow new versioning strategy (flutter/packages#12627) 2026-08-25 [email protected] [material_ui] Fixes analysis_options migration from calling `flutter pub get` on pacakage (flutter/packages#12626) 2026-08-25 [email protected] [material_ui] Declare Flutter SDK dependencies in the pubspec.yaml for tool/gen_defaults (flutter/packages#12623) 2026-08-25 [email protected] [material_ui] Set-up `tool/gen_defaults` sub-directory (flutter/packages#12469) 2026-08-25 [email protected] [google_maps_flutter] Convert top-level classes to Swift in `_sdk*` packages (flutter/packages#12307) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

…r tool/gen_defaults (flutter#12623) This is required for running the Dart analyzer within the tool/gen_defaults package.

…pub get` on pacakage (flutter#12626) Fix tool package in `material_ui`. Post submit fix for flutter#12623 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

[material_ui] Declare Flutter SDK dependencies in the pubspec.yaml fo…

1a118f7

…r tool/gen_defaults This is required for running the Dart analyzer within the tool/gen_defaults package.

jason-simmons requested review from elliette and srawlins August 25, 2026 18:32

flutter-dashboard Bot added the CICD Run CI/CD label Aug 25, 2026

github-actions Bot added p: material_ui triage-design Should be looked at in design triage labels Aug 25, 2026

elliette approved these changes Aug 25, 2026

View reviewed changes

gemini-code-assist Bot reviewed Aug 25, 2026

View reviewed changes

srawlins approved these changes Aug 25, 2026

View reviewed changes

jason-simmons added autosubmit Merge PR when tree becomes green via auto submit App emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. labels Aug 25, 2026

auto-submit Bot merged commit 0bbd8e5 into flutter:main Aug 25, 2026
10 of 12 checks passed

elliette mentioned this pull request Aug 25, 2026

Revert "[material_ui] Set-up tool/gen_defaults sub-directory" #12625

Closed

bparrishMines mentioned this pull request Aug 25, 2026

[material_ui] Fixes analysis_options migration from calling flutter pub get on pacakage #12626

Merged

11 tasks done

Navigation Menu

Repository navigation

[material_ui] Declare Flutter SDK dependencies in the pubspec.yaml for tool/gen_defaults - #12623

[material_ui] Declare Flutter SDK dependencies in the pubspec.yaml for tool/gen_defaults#12623
auto-submit[bot] merged 1 commit into
flutter:mainfrom
jason-simmons:material_gen_defaults_flutter_dep

jason-simmons commented Aug 25, 2026

Uh oh!

elliette left a comment

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Aug 25, 2026

Uh oh!

jason-simmons Aug 25, 2026

Uh oh!

flutter-dashboard Bot commented Aug 25, 2026

Uh oh!

Uh oh!

bparrishMines commented Aug 25, 2026

Uh oh!

stuartmorgan-g commented Aug 25, 2026

Uh oh!

stuartmorgan-g commented Aug 25, 2026

Uh oh!

bparrishMines commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jason-simmons commented Aug 25, 2026

Uh oh!

elliette left a comment

Choose a reason for hiding this comment

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

jason-simmons Aug 25, 2026

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard Bot commented Aug 25, 2026

Uh oh!

Uh oh!

bparrishMines commented Aug 25, 2026

Uh oh!

stuartmorgan-g commented Aug 25, 2026

Uh oh!

stuartmorgan-g commented Aug 25, 2026

Uh oh!

bparrishMines commented Aug 25, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants