Repository navigation
Conversation
…est class We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839.
srawlins
added
override: no versioning needed
github-actions
Bot
added
p: material_ui
triage-design
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the _CustomPageRoute class in packages/material_ui/test/scaffold_test.dart by removing the maintainState parameter from its constructor and instead overriding the maintainState getter to always return true. There are no review comments, and I have no feedback to provide.
Merged
10 tasks done
Collaborator
|
Why were override labels added to this PR? The tooling should not flag a |
srawlins
removed
override: no versioning needed
Contributor
Author
|
They were added because I didn't think any versioning was needed, nor any changelog. |
Collaborator
|
Thanks, I was just surprised to see the labels on a PR that said it was only changing test code, so I wanted to make sure there wasn't a tooling bug. Generally we add the labels only to actually override the tooling when its heuristic is incorrect. |
pull Bot
pushed a commit
to SaintPatricks-Github-Coinpot-Club/flutter
that referenced
this pull request
Sep 3, 2026
… class (flutter#191764) We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes. This is work towards dart-lang/sdk#47839 This is mirrored at flutter/packages#12629 ## Pre-launch Checklist - [x] I read the [Contributor Guide] and followed the process outlined there for submitting PRs. - [x] I read the [AI contribution guidelines] and understand my responsibilities, or I am not using AI tools. - [x] I read the [Tree Hygiene] wiki page, which explains my responsibilities. - [x] I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement]. - [x] I signed the [CLA]. - [x] I listed at least one issue that this PR fixes in the description above. - [x] I updated/added relevant documentation (doc comments with `///`). - [x] I added new tests to check the change I am making, or this PR is [test-exempt]. - [x] I followed the [breaking change policy] and added [Data Driven Fixes] where supported. - [x] All existing and new tests are passing. <!-- Links --> [Contributor Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview [AI contribution guidelines]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines [Tree Hygiene]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md [test-exempt]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests [Flutter Style Guide]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md [Features we expect every widget to implement]: https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement [CLA]: https://cla.developers.google.com/ [flutter/tests]: https://github.com/flutter/tests [breaking change policy]: https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes [Discord]: https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md [Data Driven Fixes]: https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
Contributor
|
Could you help fix the conflict and the failed Dashboard Checks? |
Contributor
Author
|
OK fixed conflicts a second time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already don't allow unused parameters from non-generic classes. There was a bug preventing us from reporting such parameters on generic classes.
This is work towards dart-lang/sdk#47839.
Pre-Review Checklist
[shared_preferences]///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2