Skip to content

[go_router] Update example app to iOS 11 - #3326

Merged
auto-submit[bot] merged 1 commit into
flutter:mainfrom
jmagman:gr-33
Feb 28, 2023
Merged

auto-submit[bot] merged 1 commit into
flutter:mainfrom
jmagman:gr-33

Conversation

@jmagman

@jmagman jmagman commented Feb 28, 2023

Copy link
Copy Markdown
Member

Related to flutter/flutter#101965. Built the example project on Flutter 3.3. and let the tool auto-migrate various Xcode project/Podfile files. This only touched the example app since go_router is a package, not a plugin.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman
jmagman requested a review from chunhtai as a code owner February 28, 2023 20:49
@flutter-dashboard

Copy link
Copy Markdown

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Feb 28, 2023
@auto-submit
auto-submit Bot merged commit 4397336 into flutter:main Feb 28, 2023
@jmagman
jmagman deleted the gr-33 branch March 1, 2023 00:09
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 1, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
[go_router] Update example app to iOS 11
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
[go_router] Update example app to iOS 11
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
[go_router] Update example app to iOS 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App needs tests p: go_router platform-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants