[image_picker_android] Improved Bitmap resize on Android by beroso · Pull Request #3423 · flutter/packages

beroso · 2023-03-08T19:32:35Z

Improves Bitmap load and resize on Android.

Original PR on flutter/plugins: flutter-team-archive/plugins#6947

Issue: flutter/flutter#118383

Pre-launch Checklist

gmackall · 2023-03-20T16:15:18Z

Re-requesting review from @tarrinneal and @stuartmorgan as you were both requested on the previous version of this PR.

tarrinneal · 2023-03-20T16:24:01Z

Have you run any benchmarks to see if/how much this is better than the old behaviour?

beroso · 2023-03-21T11:02:07Z

Sorry, guys. I clicked on "request review" button on @stuartmorgan requested changes, and accidentally removed @gmackall and @tarrinneal from review. It wasn't on purpose.

beroso · 2023-03-21T11:24:12Z

Have you run any benchmarks to see if/how much this is better than the old behaviour?

@tarrinneal , I just ran manual tests. I didn't do any benchmark test to compare the performance.

Before I tried to pick an 12000 x 9000 px, ~10MB image using the example app and it crashed due to an OutOfMemory error (even when the resize was not necessary).

This patch skips Bitmap decoding when resize or quality changes are not needed. Plus it can improve the resize process by subsampling image decoding depending on the maximum requested dimension.

Do you have any tips on how to benchmark it?

tarrinneal

Just a little nit for the changelog, tagging @stuartmorgan for second review.

stuartmorgan-g

LGTM, thanks!

beroso · 2023-05-10T22:29:00Z

Thank you all for the support!

By the way, the release job is running for about 4 hours. Is it normal?

stuartmorgan-g · 2023-05-11T00:42:46Z

No, release was completely broken by the 3.10 release, it turns out. I manually released it for now.

…tter/packages#3423)

flutter/packages@6328cfb...6608b60 2023-05-15 [email protected] [ci] Remove unnecessary Linux libraries (flutter/packages#3975) 2023-05-15 [email protected] [ci] Enforce a minimum Kotlin version in examples (flutter/packages#3979) 2023-05-15 [email protected] [ci] Disable Windows repo tool tests (flutter/packages#3980) 2023-05-12 [email protected] [ci] Add LUCI repo tool tests (flutter/packages#3964) 2023-05-12 [email protected] [url_launcher] Set broadcast reciever visability as required by target api 34 (flutter/packages#3973) 2023-05-12 [email protected] Update build.gradle with a comment explaining version (flutter/packages#3972) 2023-05-12 [email protected] Roll Flutter from 8c5a1ea to a76dbe4 (12 revisions) (flutter/packages#3958) 2023-05-12 [email protected] [image_picker] Fix Android lints (flutter/packages#3887) 2023-05-12 [email protected] [various] Update minimum Flutter version to 3.3 (flutter/packages#3967) 2023-05-12 [email protected] [tool] Target specific Android unit tests (flutter/packages#3955) 2023-05-12 [email protected] [camerax] Add a dependency on kotlin-bom to align versions of kotlin-stdlib (flutter/packages#3960) 2023-05-12 [email protected] [local_auth] Improve iOS test DI (flutter/packages#3959) 2023-05-12 [email protected] [ci] Ensure scripts fail if a command fails (flutter/packages#3963) 2023-05-11 [email protected] [ci] Pin the Flutter version for `release` (flutter/packages#3965) 2023-05-11 [email protected] [video_player] foundation - reduce seek accuracy to fix seek to end bug (flutter/packages#3784) 2023-05-11 [email protected] [image_picker] Fix use_build_context_synchronously violations (flutter/packages#3969) 2023-05-11 [email protected] [tool] Ensure that publish credential path is available (flutter/packages#3970) 2023-05-11 [email protected] [go_router] change `fix_data.yaml` uris to be absolute to fix lints (flutter/packages#3877) 2023-05-11 [email protected] [tool] Use new pub cache location for publish (flutter/packages#3962) 2023-05-10 [email protected] Roll Flutter (stable) from f72efea to 84a1e90 (1920 revisions) (flutter/packages#3961) 2023-05-10 [email protected] [image_picker_android] Improved Bitmap resize on Android (flutter/packages#3423) 2023-05-10 [email protected] [camerax] Add Kotlin duplicate classes known error to README.md (flutter/packages#3957) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Improves Bitmap load and resize on Android. Original PR on flutter/plugins: flutter-team-archive/plugins#6947 Issue: flutter/flutter#118383

`ImageResizer.resizeImageIfNeeded` created a fresh `BitmapFactory.Options` and passed it to `calculateSampleSize`, which read `options.outWidth` and `options.outHeight`. That object had never been used for a decode, so both were 0 and the sample size was always 1: every resize with `maxWidth` or `maxHeight` decoded the full-size bitmap (about 48 MB for a 12 MP photo) before scaling it down. The original dimensions were already read by `readFileDimensions`, into a different `Options`. This PR passes those original dimensions to `calculateSampleSize` instead. The sample size stays the largest power of two that still decodes at least the target size, so the output dimensions are unchanged. The new `onResizeImageIfNeeded_whenDownscaling_shouldSubsampleFromOriginalSize` test resizes a 12x7 image to a width of 3 and checks the pixel decode uses `inSampleSize == 2` (before the fix it was 1) and that the output is still 3x2. This is not a regression: subsampling has never taken effect, since `inSampleSize` has been 1 from when it was introduced in #3423, and before that the full image was decoded too. Fixes flutter/flutter#193036 ## Pre-Review Checklist **Note**: The Flutter team is currently trialing the use of [Gemini Code Assist for GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code). Comments from the `gemini-code-assist` bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed. [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.

Improved Bitmap resize on Android

3ce1780

beroso requested a review from gmackall as a code owner March 8, 2023 19:32

github-actions Bot added p: image_picker platform-android labels Mar 8, 2023

beroso added 8 commits March 8, 2023 17:55

Merge branch 'flutter:main' into 118383-improve-android-bitmap-resize

27423ec

Update CHANGELOG

ceb3512

Bump version

3ce3a65

Merge branch 'main' into 118383-improve-android-bitmap-resize

f7fa319

Merge branch 'main' into 118383-improve-android-bitmap-resize

7b4dab3

Refactor tests

68894c6

Fix tests

02ccb00

Merge branch 'main' into 118383-improve-android-bitmap-resize

9a8f92c

gmackall requested review from stuartmorgan-g and tarrinneal March 20, 2023 16:15

stuartmorgan-g requested changes Mar 20, 2023

View reviewed changes

Perform requested changes

ec95f40

beroso requested review from stuartmorgan-g and removed request for gmackall and tarrinneal March 21, 2023 10:56

beroso added 2 commits March 21, 2023 08:41

Rename tests

bb04c94

Merge branch 'main' into 118383-improve-android-bitmap-resize

377148d

beroso mentioned this pull request Mar 22, 2023

Update AUTHORS flutter/flutter#123266

Merged

stuartmorgan-g requested a review from tarrinneal April 4, 2023 20:08

tarrinneal reviewed Apr 13, 2023

View reviewed changes

Comment thread packages/image_picker/image_picker_android/CHANGELOG.md Outdated

tarrinneal requested changes Apr 13, 2023

View reviewed changes

Merge branch 'main' into 118383-improve-android-bitmap-resize

99fa594

beroso added 2 commits May 5, 2023 17:22

Apply suggested changes

316ba79

Merge branch 'main' into 118383-improve-android-bitmap-resize

90557a3

stuartmorgan-g approved these changes May 10, 2023

View reviewed changes

stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label May 10, 2023

auto-submit Bot merged commit a1929a6 into flutter:main May 10, 2023

reidbaker mentioned this pull request May 12, 2023

[url_launcher] Set broadcast reciever visability as required by target api 34 #3973

Merged

8 of 11 tasks

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126832

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

a1929a6 [image_picker_android] Improved Bitmap resize on Android (flu…

3f0dfa1

…tter/packages#3423)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 8febbba0c387 (21 revisions) flutter/flutter#126859

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

a1929a6 [image_picker_android] Improved Bitmap resize on Android (flu…

1c90faa

…tter/packages#3423)

engine-flutter-autoroll mentioned this pull request May 15, 2023

Roll Packages from 6328cfbd2a46 to 6608b604b0e7 (22 revisions) flutter/flutter#126865

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 15, 2023

a1929a6 [image_picker_android] Improved Bitmap resize on Android (flu…

1b35a0d

…tter/packages#3423)

This was referenced Jul 7, 2023

[Tool] New tool to download android dependencies #4408

Merged

[camera] tree fix format 2023 05 12 #4450

Closed

[tooling] mark infra steps as infra steps in yaml files #4473

Merged

reidbaker mentioned this pull request Jul 26, 2023

[Tooling] Add google owned cache for dependencies as an option in ci #4567

Merged

10 of 11 tasks

reidbaker mentioned this pull request Aug 4, 2023

[All] Expand artifact hub to all plugins #4645

Merged

10 of 11 tasks

beroso mentioned this pull request Jun 13, 2026

[image_picker] Improving Bitmap resize performance on Android flutter/flutter#118383

Closed

FatJohn mentioned this pull request Sep 19, 2026

[image_picker_android] ImageResizer never downsamples: calculateSampleSize reads an Options object that was never decoded flutter/flutter#193036

Closed

anilcancakir mentioned this pull request Sep 27, 2026

[image_picker] Subsample large images when resizing on Android #13038

Merged

10 of 11 tasks

Navigation Menu

Repository navigation

[image_picker_android] Improved Bitmap resize on Android - #3423

[image_picker_android] Improved Bitmap resize on Android#3423
auto-submit[bot] merged 19 commits into
flutter:mainfrom
beroso:118383-improve-android-bitmap-resize

beroso commented Mar 8, 2023 •

edited

Loading

Uh oh!

gmackall commented Mar 20, 2023

Uh oh!

tarrinneal commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beroso commented Mar 21, 2023

Uh oh!

beroso commented Mar 21, 2023 •

edited

Loading

Uh oh!

Uh oh!

tarrinneal left a comment

Uh oh!

stuartmorgan-g left a comment

Uh oh!

beroso commented May 10, 2023

Uh oh!

stuartmorgan-g commented May 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

beroso commented Mar 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

gmackall commented Mar 20, 2023

Uh oh!

tarrinneal commented Mar 20, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

beroso commented Mar 21, 2023

Uh oh!

beroso commented Mar 21, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

tarrinneal left a comment

Choose a reason for hiding this comment

Uh oh!

stuartmorgan-g left a comment

Choose a reason for hiding this comment

Uh oh!

beroso commented May 10, 2023

Uh oh!

stuartmorgan-g commented May 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

beroso commented Mar 8, 2023 •

edited

Loading

beroso commented Mar 21, 2023 •

edited

Loading