Skip to content

Skip failing legacy test - #3526

Merged
tarrinneal merged 1 commit into
flutter:mainfrom
bparrishMines:skip_test
Mar 23, 2023
Merged

tarrinneal merged 1 commit into
flutter:mainfrom
bparrishMines:skip_test

Conversation

@bparrishMines

@bparrishMines bparrishMines commented Mar 23, 2023 •

Copy link
Copy Markdown
Contributor

See flutter/flutter#123327

No version bump since this only changes the test of unused legacy code.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@tarrinneal

Copy link
Copy Markdown
Contributor

Merging on red to fix tree

@tarrinneal
tarrinneal merged commit af36411 into flutter:main Mar 23, 2023
@bparrishMines
bparrishMines deleted the skip_test branch March 23, 2023 15:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 23, 2023
nploi pushed a commit to nploi/packages that referenced this pull request Jul 16, 2023
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants