Repository navigation
[go_router]Show ShellRoute's routes in debug log - #3664
auto-submit[bot] merged 8 commits into
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
4ab7871 to
1666e48
Compare
5d0c5fc to
86e1e14
Compare
| } | ||
|
|
||
| String _debugKnownRoutes() { | ||
| /// Returns full paths of all routes and known full paths of route names. |
There was a problem hiding this comment.
what's known full paths of route names. Can you make it more clear?
Co-authored-by: chunhtai <[email protected]>
Co-authored-by: chunhtai <[email protected]>
chunhtai
left a comment
There was a problem hiding this comment.
sorry i missed this one, this should be the last one
[go_router]Show ShellRoute's routes in debug log
[go_router]Show ShellRoute's routes in debug log
[go_router]Show ShellRoute's routes in debug log
Fixes flutter/flutter#113819
Fix ShellRoute's sub routes to log output when
debugLogDiagnosticsistrue.In
example/lib/shell_route.dart, the following log is output.Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.