Skip to content

[go_router] Update link to example for query and path parameters - #3994

Merged
auto-submit[bot] merged 6 commits into
flutter:mainfrom
nilsreichardt:update-query-and-path-parameter-example
Jun 8, 2023
Merged

auto-submit[bot] merged 6 commits into
flutter:mainfrom
nilsreichardt:update-query-and-path-parameter-example

Conversation

@nilsreichardt

@nilsreichardt nilsreichardt commented May 15, 2023 •

Copy link
Copy Markdown
Contributor

This PR updates the link to the example for query and path parameters because the old link doesn't exist anymore.

image

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

Comment thread packages/go_router/CHANGELOG.md Outdated
@chunhtai
chunhtai requested a review from hannah-hyj May 15, 2023 16:31
@stuartmorgan-g

Copy link
Copy Markdown
Collaborator

Could you update the PR to have a description, rather than just the placeholder about having a description?

@nilsreichardt

Copy link
Copy Markdown
Contributor Author

Could you update the PR to have a description, rather than just the placeholder about having a description?

Updated ✅

@chunhtai

chunhtai commented Jun 2, 2023

Copy link
Copy Markdown
Contributor

@nilsreichardt can you fix the merge conflict?

@nilsreichardt

Copy link
Copy Markdown
Contributor Author

@chunhtai resolved ☑️

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 8, 2023
@auto-submit
auto-submit Bot merged commit f6633b2 into flutter:main Jun 8, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 9, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jun 9, 2023
flutter/packages@e13b8c4...afe2f05

2023-06-08 [email protected] [image_picker] Add desktop support - platform interface (flutter/packages#4161)
2023-06-08 [email protected] [go_router] Update link to example for query and path parameters (flutter/packages#3994)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [in_app_pur]: Bump org.jetbrains.kotlin:kotlin-bom from 1.8.0 to 1.8.21 in /packages/in_app_purchase/in_app_purchase_android/android (flutter/packages#3839)
2023-06-08 49699333+dependabot[bot]@users.noreply.github.com [image_picker]: Bump androidx.activity:activity from 1.7.0 to 1.7.1 in /packages/image_picker/image_picker_android/android (flutter/packages#3768)
2023-06-08 [email protected] [webview_flutter] Explicitly disable ATS in example apps (flutter/packages#4166)
2023-06-08 [email protected] Roll Flutter from 8a5c22e to 6e254a3 (12 revisions) (flutter/packages#4165)
2023-06-08 [email protected] Fix stale ignore: prefer_const_constructors from flutter/packages (flutter/packages#4154)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
10 of 11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
…tter#3994)

This PR updates the link to the example for query and path parameters because the old link doesn't exist anymore.

<img width="1440" alt="image" src="https://github.com/flutter/packages/assets/24459435/0e65d9a5-b53e-4b0e-95b2-ad4953545625">
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
…tter#3994)

This PR updates the link to the example for query and path parameters because the old link doesn't exist anymore.

<img width="1440" alt="image" src="https://github.com/flutter/packages/assets/24459435/0e65d9a5-b53e-4b0e-95b2-ad4953545625">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants