Skip to content

[go_router_builder] Accept required parameters not in path - #4039

Merged
auto-submit[bot] merged 10 commits into
flutter:mainfrom
ValentinVignal:go-router-builder/accept-required-parameters-not-in-path
Jun 7, 2023
Merged

auto-submit[bot] merged 10 commits into
flutter:mainfrom
ValentinVignal:go-router-builder/accept-required-parameters-not-in-path

Conversation

@ValentinVignal

Copy link
Copy Markdown
Contributor

This PR allows required/positional parameters to not be in the path.

Fixes flutter/flutter#126796

If you had to change anything in the flutter/tests repo, include a link to the migration guide as per the breaking change policy.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

…ccept-required-parameters-not-in-path

# Conflicts:
#	packages/go_router_builder/CHANGELOG.md
#	packages/go_router_builder/pubspec.yaml
@ValentinVignal

Copy link
Copy Markdown
Contributor Author

@chunhtai Is there anything I should do about this PR ?

@chunhtai
chunhtai requested a review from hannah-hyj June 1, 2023 21:45
@chunhtai

chunhtai commented Jun 5, 2023

Copy link
Copy Markdown
Contributor

@Hangyujin is the primary reviewer

@hannah-hyj hannah-hyj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai chunhtai added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 7, 2023
@auto-submit
auto-submit Bot merged commit f1e628c into flutter:main Jun 7, 2023
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 8, 2023
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Jun 8, 2023
flutter/packages@a84b2c2...e13b8c4

2023-06-08 [email protected] [tool] Only run unit tests in Chrome for inline web (flutter/packages#4153)
2023-06-08 [email protected] [in_app_purchase] Make the _FeatureCard constructor const in the Android example app (flutter/packages#4162)
2023-06-08 [email protected] [shared_preferences] Fix initialization race (flutter/packages#4159)
2023-06-07 [email protected] [go_router] Refactors imperative APIs and browser history (flutter/packages#4134)
2023-06-07 [email protected] [various] Add `http` 1.0 compatibility (flutter/packages#4147)
2023-06-07 [email protected] [go_router_builder] Accept required parameters not in path (flutter/packages#4039)
2023-06-07 [email protected] Roll Flutter from 0b74153 to 8a5c22e (46 revisions) (flutter/packages#4160)
2023-06-07 [email protected] [pigeon] Require analyzer 5.13.0, prepare for NamedType refactoring. (flutter/packages#4127)
2023-06-07 [email protected] Roll Flutter (stable) from f92f441 to 682aa38 (1 revision) (flutter/packages#4157)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@reidbaker reidbaker mentioned this pull request Aug 4, 2023
10 of 11 tasks
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
)

This PR allows required/positional parameters to not be in the path.

Fixes flutter/flutter#126796

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
)

This PR allows required/positional parameters to not be in the path.

Fixes flutter/flutter#126796

*If you had to change anything in the [flutter/tests] repo, include a link to the migration guide as per the [breaking change policy].*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App p: go_router_builder

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[go_router_builder] Allow required query parameters

3 participants