Repository navigation
[url_launcher] Remove nested third_party safari checker - #4330
Merged
Merged
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
ditman
requested changes
Jun 28, 2023
ditman
left a comment
ditman
left a comment
Member
There was a problem hiding this comment.
Thanks for your contribution @victorsanni!
It needs a few fixes to land. Please check the failed "Checks" section for more info (I copied the most relevant bits under some of my comments). All checks need to pass before we can merge this!
Thanks!
Member
|
The feature is tested, tests exist here: |
ditman
approved these changes
Jun 29, 2023
ditman
added
autosubmit
Member
|
Thanks @victorsanni! This'll auto-land soon! |
auto-submit
Bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/packages, pr: 4330, due to This PR has not met approval requirements for merging. You are not a member of flutter-hackers and need 1 more review(s) in order to merge this PR.
|
stuartmorgan-g
approved these changes
Jun 29, 2023
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
Collaborator
There was a problem hiding this comment.
LGTM with nit.
Do were already have tests covering Safari detection?
Member
The tests verify that stuff works as expected when a navigator identifies itself as Safari (and when it doesn't). We don't have tests running on Safari though, the difference is tested by mocking the navigator values. |
Removed redundant check for 'Apple Computer, Inc.' vendor
ditman
reviewed
Jul 5, 2023
ditman
reviewed
Jul 6, 2023
Co-authored-by: David Iglesias <[email protected]>
Member
|
I think this is ready to go! Thanks @victorsanni for the clean-up! |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 7, 2023
auto-submit Bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 7, 2023
flutter/packages@771ec9b...9bcf4bf 2023-07-07 [email protected] [ci] Add LUCI web platform tests (flutter/packages#4391) 2023-07-07 [email protected] [webview_flutter] Enable unawaited_futures lint (flutter/packages#4271) 2023-07-07 [email protected] [ci] Add partial LUCI version of repo_checks (flutter/packages#4389) 2023-07-06 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.1.3 to 2.2.0 (flutter/packages#4302) 2023-07-06 [email protected] [webview_flutter_android][webview_flutter_wkwebview] Fixes unawaited_futures violations (flutter/packages#4354) 2023-07-06 [email protected] [local_auth] Update Windows Pigeon version (flutter/packages#4388) 2023-07-06 [email protected] [url_launcher] Remove nested third_party safari checker (flutter/packages#4330) 2023-07-06 [email protected] [ci] Add partial LUCI Android platform tests (flutter/packages#4381) 2023-07-06 [email protected] [ci] Switch `master` Linux custom package tests to LUCI (flutter/packages#4386) 2023-07-06 [email protected] [go_router] Exposes package-level privates (flutter/packages#4380) 2023-07-06 [email protected] [file_selector] Update to 1.0 (flutter/packages#4362) 2023-07-06 [email protected] Roll Flutter from 35085c3 to bc49cd1 (14 revisions) (flutter/packages#4387) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
This was referenced Jul 7, 2023
10 of 11 tasks
10 of 11 tasks
11 tasks done
auto-submit Bot
pushed a commit
that referenced
this pull request
May 5, 2026
The third-party code in `url_launcher_web` was removed in #4330, and `bsdiff` was removed in #502, but we never removed: - The top-level LICENSE file entry for the code in `url_launcher_web` - The repo tooling allowance for those copyright/license blocks This removes those remaining pieces. Part of flutter/flutter#129575 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
Remove nested third_party safari checker - Replace nested third party safari checker with clean room implementation. - Fixes flutter/flutter#129575 - [x ] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.)
creatorpiyush
pushed a commit
to creatorpiyush/packages
that referenced
this pull request
Jun 10, 2026
The third-party code in `url_launcher_web` was removed in flutter#4330, and `bsdiff` was removed in flutter#502, but we never removed: - The top-level LICENSE file entry for the code in `url_launcher_web` - The repo tooling allowance for those copyright/license blocks This removes those remaining pieces. Part of flutter/flutter#129575 ## Pre-Review Checklist [^1]: Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling.
bisor0627
pushed a commit
to bisor0627/packages
that referenced
this pull request
Jun 19, 2026
Remove nested third_party safari checker - Replace nested third party safari checker with clean room implementation. - Fixes flutter/flutter#129575 - [x ] I read and followed the [relevant style guides] and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use `dart format`.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove nested third_party safari checker
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.